Maurits py3 only code quality no pkg resources - #222
Conversation
Got rid of code that tried to support `zc.buildout` 1.4.
Move the remaining requirements inline, instead of defining them above the setup call.
This is instead of an ugly error:
```
$ bin/develop
Traceback (most recent call last):
File "/Users/maurits/community/plone-coredev/6.1/bin/develop", line 15, in <module>
sys.exit(mr.developer.develop.develop())
File "/Users/maurits/shared-eggs/cp310/mr.developer-2.0.4-py3.10.egg/mr/developer/develop.py", line 103, in __call__
args.func(args)
AttributeError: 'Namespace' object has no attribute 'func'
```
|
This is ready for review. It is part of a stack of three PRs that build on each other, but can be merged and reviewed separately if wanted, starting with the first. Or just merge the current one and all others will be merged automatically in the right order.
The first two contain lots and lots of code changes, but mostly automatic with You can review per commit and skip the giant automatic ones. Or just try it out. Pinging @mamico and @janjaapdriessen for review, as you have been active in this repo lately, with your improvements landing in 2.1.0 which I have released today. cc @gforcada @icemac @dataflake as they may also want to have a look (also at the released 2.1.0 changes). I have asked for review from original author @fschulze, but I have not seen him active in this repo for a long time, so he may no longer be using it. |
|
Thanks for the reviews! |
|
@mauritsvanrees I'm still using it, but I had no issues and you are doing a fantastic job! |
4 participants
Fixes issue #218.