Do not archive a duplicate when a write reuses the live generation - #2323
Open
gaul wants to merge 1 commit into
Open
Do not archive a duplicate when a write reuses the live generation#2323gaul wants to merge 1 commit into
gaul wants to merge 1 commit into
Conversation
PatchObject and the ACL handlers persist through CreateObject carrying the object's existing generation. On a versioning-enabled bucket every such metadata update archived a copy of the live object under the same generation it still holds, so a single ACL change made a versioned listing show two entries sharing an id. A write that reuses the live generation now replaces it in place; only a write that changes the generation archives the old one, matching Cloud Storage, where a metadata update bumps the metageneration alone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PatchObject and the ACL handlers persist through CreateObject carrying the object's existing generation. On a versioning-enabled bucket every such metadata update archived a copy of the live object under the same generation it still holds, so a single ACL change made a versioned listing show two entries sharing an id. A write that reuses the live generation now replaces it in place; only a write that changes the generation archives the old one, matching Cloud Storage, where a metadata update bumps the metageneration alone.