Skip to content

Conversation

@Thorium
Copy link
Member

@Thorium Thorium commented Oct 28, 2025

Just minor tweaks.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Test Results

   12 files  ±0     12 suites  ±0   36m 28s ⏱️ + 3m 8s
  451 tests ±0    450 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 287 runs  ±0  1 284 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 13b3dbd. ± Comparison against base commit d7c71ed.

♻️ This comment has been updated with latest results.

@xperiandri xperiandri requested a review from Copilot October 28, 2025 15:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves security and performance by updating deprecated cryptographic APIs, fixing insecure JSON deserialization, and reducing polling delays.

Key changes:

  • Replaces deprecated AesManaged with Aes.Create() in vault encryption
  • Adds secure JSON deserialization settings to prevent type name handling attacks
  • Reduces process wait polling interval from 1000ms to 100ms

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/app/Fake.Core.Vault/Vault.fs Updates AES encryption API and secures JSON deserialization with explicit settings
src/app/Fake.Core.Process/Process.fs Reduces process polling delay and removes BOM character

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@xperiandri xperiandri merged commit 74e1e6f into fsprojects:master Oct 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants