Implemented LINQ query optimization for ObjectListFilter
#520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperiandri
requested changes
Mar 20, 2025
Comment on lines
+276
to
+281
| if options.Optimize then | ||
| let body = ExpressionOptimizer.visit(buildFilterExpr (SourceExpression param) buildTypeDiscriminatorCheck filter) | ||
| whereExpr<'T> query param body | ||
| else | ||
| let body = buildFilterExpr (SourceExpression param) buildTypeDiscriminatorCheck filter | ||
| whereExpr<'T> query param body |
There was a problem hiding this comment.
Suggested change
| if options.Optimize then | |
| let body = ExpressionOptimizer.visit(buildFilterExpr (SourceExpression param) buildTypeDiscriminatorCheck filter) | |
| whereExpr<'T> query param body | |
| else | |
| let body = buildFilterExpr (SourceExpression param) buildTypeDiscriminatorCheck filter | |
| whereExpr<'T> query param body | |
| if options.Optimize then | |
| buildFilterExpr (SourceExpression param) buildTypeDiscriminatorCheck filter | |
| |> ExpressionOptimizer.visit | |
| else | |
| buildFilterExpr (SourceExpression param) buildTypeDiscriminatorCheck filter | |
| |> whereExpr<'T> query param |
| ||| (("firstName" @=@ "a") | ||
| ||| ("lastName" @=@ "a")))))) | ||
| let queryable = data.AsQueryable () | ||
| let filteredData = queryable.Apply (filter, ObjectListFilterLinqOptions(optimize = true)) |> Seq.toList |
There was a problem hiding this comment.
Suggested change
| let filteredData = queryable.Apply (filter, ObjectListFilterLinqOptions(optimize = true)) |> Seq.toList | |
| let filteredData = queryable.Apply (filter, ObjectListFilterLinqOptions (optimize = true)) |> Seq.toList |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.