Add InterpolatedStringWithNoSubstitution rule #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Let's also flag sprintfs where there is no % element. |
Contributor
Author
Mention both cases in docs and warning message? This might turn out to be confusing. |
Collaborator
|
Not confusing at all, both cases are string interpolation without real interpolation. Just generalize the docs. |
webwarrior-ws
force-pushed
the
interpolated-strings
branch
2 times, most recently
from
d62174c to
a1f7dc6
Compare
Contributor
Author
Updated the docs. I can't say I like the new warning message, but couldn't come up with anything better. |
knocte
reviewed
Nov 19, 2025
knocte
reviewed
Nov 19, 2025
knocte
reviewed
Nov 19, 2025
src/FSharpLint.Core/Rules/Smells/InterpolatedStringWithNoSubstitution.fs
Outdated
Show resolved
Hide resolved
knocte
reviewed
Nov 19, 2025
knocte
reviewed
Nov 19, 2025
Collaborator
Please 0.26.8 |
webwarrior-ws
force-pushed
the
interpolated-strings
branch
from
9d3a2a9 to
94eb889
Compare
Contributor
Author
Changed version to 0.26.8. |
knocte
reviewed
Nov 20, 2025
knocte
reviewed
Nov 20, 2025
src/FSharpLint.Core/Rules/Smells/InterpolatedStringWithNoSubstitution.fs
Outdated
Show resolved
Hide resolved
knocte
reviewed
Nov 20, 2025
knocte
reviewed
Nov 20, 2025
tests/FSharpLint.Core.Tests/Rules/Smells/InterpolatedStringWithNoSubstitution.fs
Outdated
Show resolved
Hide resolved
knocte
reviewed
Nov 20, 2025
tests/FSharpLint.Core.Tests/Rules/Smells/InterpolatedStringWithNoSubstitution.fs
Outdated
Show resolved
Hide resolved
webwarrior-ws
force-pushed
the
interpolated-strings
branch
2 times, most recently
from
c2a0f22 to
ca74de0
Compare
Collaborator
|
Let's squash commits properly and I'll merge. |
webwarrior-ws
force-pushed
the
interpolated-strings
branch
2 times, most recently
from
f74acb7 to
b06991e
Compare
knocte
reviewed
Nov 20, 2025
tests/FSharpLint.Core.Tests/Rules/Smells/InterpolatedStringWithNoSubstitution.fs
Outdated
Show resolved
Hide resolved
knocte
reviewed
Nov 20, 2025
tests/FSharpLint.Core.Tests/Rules/Smells/InterpolatedStringWithNoSubstitution.fs
Outdated
Show resolved
Hide resolved
webwarrior-ws
force-pushed
the
interpolated-strings
branch
from
b06991e to
3fb96a1
Compare
Collaborator
|
Tests failed, maybe the rule was expecting pipe only? |
Created tests for InterpolatedStringWithNoSubstitution rule. Contains failing tests.
Implemented InterpolatedStringWithNoSubstitution rule.
Added docs and configuration for InterpolatedStringWithNoSubstitution rule. Enabled this rule by default.
Use regular string instead of interpolated string because there are no embedded expressions in that string. Use `failwith` instead of `failwithf` where there is no string substitution.
webwarrior-ws
force-pushed
the
interpolated-strings
branch
from
ad0c9a0 to
c5cad2d
Compare
Contributor
Author
No, position of expected error changed slightly. Already fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added InterpolatedStringWithNoSubstitution rule that checks for usage of interpolated strings (with
$prefix, such as$"foo") without embedded F# expression (e.g.$"{foo}"where foo is some value).