Skip to content

Refactor StringOfSym function - remove ML syntax #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nojaf merged 3 commits into from
Dec 15, 2025
Merged

Refactor StringOfSym function - remove ML syntax #235

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f52e617
Refactor StringOfSym function - remove ML syntax
T-Gro Dec 15, 2025
282f539
Refactor string concatenation in fsyaccast.fs
T-Gro Dec 15, 2025
529fc22
fantomas'd
T-Gro Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/FsYacc.Core/fsyaccast.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ type Symbols = Symbol list

let StringOfSym sym =
match sym with
| Terminal s -> "'" ^ s ^ "'"
| Terminal s -> String.Concat("'", s, "'")
| NonTerminal s -> s

let OutputSym os sym = fprintf os "%s" (StringOfSym sym)
Expand Down Expand Up @@ -461,7 +461,9 @@ let CompilerLalrParserSpec logf (spec: ProcessedParserSpec) : CompiledSpec =
stopWatch.Start()

// Augment the grammar
let fakeStartNonTerminals = spec.StartSymbols |> List.map (fun nt -> "_start" ^ nt)
let fakeStartNonTerminals =
spec.StartSymbols |> List.map (fun nt -> String.Concat("_start", nt))

let nonTerminals = fakeStartNonTerminals @ spec.NonTerminals
let endOfInputTerminal = "$$"
let dummyLookahead = "#"
Expand Down Expand Up @@ -620,7 +622,7 @@ let CompilerLalrParserSpec logf (spec: ProcessedParserSpec) : CompiledSpec =

let StringOfSym sym =
match sym with
| PTerminal s -> "'" ^ termTab.OfIndex s ^ "'"
| PTerminal s -> String.Concat("'", termTab.OfIndex s, "'")
| PNonTerminal s -> ntTab.OfIndex s

let OutputSym os sym = fprintf os "%s" (StringOfSym sym)
Expand Down