Support pack of global tools (PackAsTool)#3208
Merged
forki merged 4 commits intofsprojects:masterfrom May 18, 2018
Merged
Conversation
Otherwise if the PackAsTool property is global (from commandline) the p2p deps are not added
Collaborator
Author
Collaborator
Author
matthid
approved these changes
May 17, 2018
Member
matthid
left a comment
There was a problem hiding this comment.
Yes looks good! We just need to remember to enable the tests later on, maybe we can add a bullet-point in the linked PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require .net sdk >= 2.1.300
using
PackAsToolwithPacktarget, allow to create tools (for .net core are FDD)this PR:
if is just a console app (no p2p, deps are ok).
if you want, just put the nupkg in a reachable feed (local is ok), and do
dotnet tool install mytool -g(global) ordotnet tool install mytool --tool-path "%CD%\dir_with_tools"(to put tools indir_with_tools, sodir_with_tools\mytoolwill work)if is a console app with p2p, put the
PackAsToolproperty inside the fsproj, otherwise the p2p deps are not added in the nupkg.NOTE if we modify the condition to check the type (lib vs exe), will be possibile to allow also
/p:PackAsTool=truewith p2p, but i dont care atmTests are disabled atm (but works), i'll upgrade everything to 2.1.300-rc1 with #3183 so can be run