Skip to content

consider dependencies target framework restrictions in paket pack#3558

Closed
enricosada wants to merge 4 commits intofsprojects:masterfrom
enricosada:paket_pack_by_tfm
Closed

consider dependencies target framework restrictions in paket pack#3558
enricosada wants to merge 4 commits intofsprojects:masterfrom
enricosada:paket_pack_by_tfm

Conversation

@enricosada
Copy link
Collaborator

@enricosada enricosada commented Apr 19, 2019

Scenario: there are framework restrictions (like framework: net461) in paket.dependencies or paket.references

The paket pack should consider these and filter dependencies for the nuspec target framework groups

Before, all packages where added in all target framework groups

@enricosada enricosada changed the title consider dependencies target framework restriction in paket pack consider dependencies target framework restrictions in paket pack Apr 19, 2019
@enricosada
Copy link
Collaborator Author

enricosada commented Apr 19, 2019

@forki ready to review.

the travis failure is unrelated, the build job doesnt start because cannot install the .net core sdk with apt

@enricosada enricosada requested a review from forki April 19, 2019 15:28
@forki forki mentioned this pull request May 8, 2019
@forki
Copy link
Member

forki commented May 8, 2019

replaced by #3573

@forki forki closed this May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants