Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix pathToExtension in FsiExtension tests. #3922

Open
wants to merge 5 commits into
base: fsharp5
Choose a base branch
from

Conversation

smoothdeveloper
Copy link
Contributor

No description provided.

@smoothdeveloper
Copy link
Contributor Author

I'm actually confused with <OutputPath> not being honored on a call to build.cmd.

@forki
Copy link
Member

forki commented Oct 24, 2020

yeah I'm confused as hell

@smoothdeveloper
Copy link
Contributor Author

Ok, there is a problem with the output path being inconsistent between build from IDE and build script, the other issue I suspect is that we need a binding redirect for another assembly than just FSharp.Core in the FCS test.

For the first issue, something like the pathToExtension hack in this branch may be good work around for now.

For the second, this is confusing error because the loading mechanism will silently move on from an extension assembly that can't be loaded (due to binding redirect issue), this is the reason

System.AppDomain.CurrentDomain.add_AssemblyResolve(fun _ (e: System.ResolveEventArgs) ->
// the paket dependency manager assembly depends on fsharp.core version
// which may not be the same as hosting process
if e.Name.StartsWith "FSharp.Core," then
printfn "binding redirect for FSharp.Core..."
typedefof<Map<_,_>>.Assembly
else
e.RequestingAssembly
)
was put in place.

Does FSharp.Core 5 depends on additional thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants