[Repo Assist] Add regression test for index-without-dot with variable key and unit args (#2519)#3311
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
…args, 2519 Add a regression test for the specific scenario from issue #2519: using a variable as the index key followed by unit arguments should not add spurious spaces around the index. The bug was fixed by PR #3259 (Fix index-without-dot followed by application arguments). This test ensures the specific pattern reported in #2519 remains correctly formatted. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nojaf
approved these changes
Mar 24, 2026
Contributor
|
/repo-assist format the code |
Contributor
Author
|
🚀 Repo Assist has started processing this issue comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Closes #2519 (regression test only — fix already shipped in #3259)
Summary
Adds a regression test for the specific scenario reported in #2519: using a variable as the index key in
dict[key]syntax followed by unit argument(s) should not add spurious spaces.Before fix (pre-#3259):
After fix (post-#3259):
Root Cause
The fix in PR #3259 modified
ASTTransformer.fsandCodePrinter.fsto stop flattening throughIndexWithoutDotnodes, preventing spurious space insertion around variable-key index expressions.What This PR Does
index without dot with variable key followed by two unit arguments, 2519toIndexSyntaxTests.fs[Unreleased]> Fixed (as requested by@nojaf)Test Status
Build and tests passed locally: