[2.x] Make consumer DisposeAsync execute in the backgroundTask (#309) #310
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Make consumer DisposeAsync execute in the backgroundTask * Update pulsar test image --------- Co-authored-by: Vladimir Shchur <[email protected]> (cherry picked from commit 096bc23)
|
Could you help take a look at the CI error? Seems not related to this PR. |
|
@RobertIndie Ubuntu image needs to be updated |
Thanks. The CI has passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick: #309
Motivation
The
producer.DisposeAsyncruns in the background, while the consumer does not. This can cause inconsistent behavior between closing the producer and the consumer. For example, if a user wants to wait for the result ofconsumer.DisposeAsyncusingGetAwaiter, it may lead to a deadlock ifConfigureAwait(false)is not set. It is better to run this dispose in the background to avoid deadlock issues and to ensure consistent behavior with the producer.Co-authored-by: Vladimir Shchur [email protected]
(cherry picked from commit 096bc23)