Skip to content

Conversation

@littleEast7
Copy link
Collaborator

To avoid exhausting worker connections, long-lived connection support was removed on the client side.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes long-lived connection support from the Alluxio client to prevent exhausting worker connections. The changes eliminate session-based HTTP requests in favor of direct requests.get() calls, and remove the associated concurrency configuration parameter.

Key changes:

  • Removed session creation and management from AlluxioClient class
  • Replaced all self.session.get() calls with direct requests.get() calls
  • Removed concurrency parameter from configuration

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
config_template.yaml Removed concurrency configuration documentation and default value
alluxiofs/client/config.py Removed concurrency parameter, validation, and instance variable from AlluxioClientConfig
alluxiofs/client/core.py Removed session initialization in AlluxioClient and replaced session-based HTTP calls with direct requests library calls
Comments suppressed due to low confidence (1)

alluxiofs/client/core.py:2240

  • The requests.request() function is being used incorrectly in an async context. The requests library is synchronous and does not support async/await or context managers. This line should use self.session.request() instead, where self.session is the aiohttp.ClientSession instance created in _set_session(). This will cause a runtime error when this async method is called.
        async with requests.request(
            method=method.value,
            url=url,
            params=params,
            json=json,
            headers=headers,
            data=data,
            timeout=None,
        ) as r:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@littleEast7 littleEast7 merged commit fc4068c into fsspec:main Dec 26, 2025
9 checks passed
@littleEast7 littleEast7 self-assigned this Dec 26, 2025
@littleEast7 littleEast7 added the enhancement New feature or request label Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant