fix(ci): wire correct go-semantic-release outputs and Node 24 env#118
Closed
fix(ci): wire correct go-semantic-release outputs and Node 24 env#118
Conversation
Previous SHA was invented and resolved to no tag.
The action emits 'version' (not 'new-release-version') and does not publish a 'new-release-published' flag — my previous workflow read nonexistent outputs, so 'published' was always empty and every downstream job skipped. Derive both outputs from the single 'version' output instead. Also set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level so the Node 20-based action runs on Node 24 per GitHub's deprecation notice. Drops allow-initial-development-versions=false since we're now past v1.0.0 and the flag only affects the 0.x → 1.0 transition.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 86.80% 86.80%
=======================================
Files 86 86
Lines 7155 7155
=======================================
Hits 6211 6211
Misses 717 717
Partials 227 227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs in #117's workflow:
Downstream jobs always skipped. I used output names from
cycjimmy/semantic-release-action(new-release-published,new-release-version) but we actually usego-semantic-release/action, which emitsversionand never sets apublishedflag. Thepublishedoutput was empty, so every job gated onneeds.version.outputs.published == 'true'was skipped — includinggoreleaser. That's why v1.0.0 tag was created but no binaries shipped.Node 20 deprecation warning.
go-semantic-release/action@v1.24.1still runs on Node 20. SettingFORCE_JAVASCRIPT_ACTIONS_TO_NODE24=trueat the workflow level silences the warning and opts in early, ahead of the 2026-09-16 removal.Also drops
allow-initial-development-versions: false— we're past v1.0.0, so the flag is moot (it only controls the 0.x→1.0 boundary).Next commit behaviour
After merge, this
fix(ci):commit will drive a patch bump → v1.0.1, and goreleaser will upload binaries (server + mcp-client × 5 platforms) to that release.v1.0.0 has no binaries
The already-published v1.0.0 release is empty. To backfill it, run locally once:
git fetch --tags git checkout v1.0.0 GITHUB_TOKEN=$(gh auth token) goreleaser release --cleanOr skip — v1.0.1 will carry the first real set of binaries a minute after merging this PR.
Test plan
published=truein the version job outputgoreleaserjob runs, uploads 10 archives + checksums to the v1.0.1 release