Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to font renamer to allow overwriting files. #181

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

SolidTux
Copy link
Contributor

This exposes the overwrite option of makeOutputFilename as a command line flag.

@ftCLI
Copy link
Owner

ftCLI commented Jul 18, 2024

There's the risk, especially when processing a large number of files, that some of them could be deleted without warning. I see that in your PR the default value is False, and that's ok. Could you just add a warning in the help string so to make clear to the users that they coul loose files with that option active?

@SolidTux
Copy link
Contributor Author

That makes sense. Maybe like this?

@ftCLI ftCLI merged commit 4b7e495 into ftCLI:main Jul 19, 2024
3 checks passed
@ftCLI
Copy link
Owner

ftCLI commented Jul 19, 2024

That makes sense. Maybe like this?

Yep. Thanks!

@SolidTux
Copy link
Contributor Author

Thank you for the yet again superfast and helpful response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants