Skip to content
This repository was archived by the owner on Jun 9, 2022. It is now read-only.

Conversation

@matthew-andrews
Copy link
Contributor

As discussed here.

Also a bit of spring cleaning:

  • Updating dependencies
  • Jshinting tests (not completely fixed issues here - but mostly)
  • Updating tests to use busterjs's latest version.

DONT MERGE YET

  • I've broken bower. To be continued...

@wilsonpage
Copy link
Contributor

I think the test suite depends on the built version. Also I think we require the standalone option for the Browserify build.

@matthew-andrews
Copy link
Contributor Author

For the test suite I should have solved that with:
c464313

Weirdly it was coveralls that caused the failed build for this:
https://travis-ci.org/ftlabs/fruitmachine/builds/16870463

I'm not sure what you mean by standalone option?

@@ -15,6 +17,7 @@ buster.testCase('View#destroy()', {

this.view.destroy();

assert.called(destroy);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spy didn't appear to have any assertions on it.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling df60587 on nocompiled into 446522b on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling df60587 on nocompiled into 446522b on master.

@ghost ghost assigned orangemug Jan 15, 2014
@matthew-andrews
Copy link
Contributor Author

Jamie @orangemug would you mind having a look at this?

@wilsonpage
Copy link
Contributor

Do we still want to do this following the Bower debacle?

@matthew-andrews
Copy link
Contributor Author

Yes but not yet. I've got it to build with some forks of the dependencies with minimal changes to them (just adding bower.jsons) with debowerify.

@matthew-andrews
Copy link
Contributor Author

Pull requests here:

wilsonpage/extend#2
wilsonpage/utils#1
wilsonpage/mixin#1

@kornelski
Copy link
Contributor

Can we drop support for Bower?

@apaleslimghost
Copy link
Contributor

#87 :)

matthew-andrews and others added 3 commits April 14, 2015 17:44
…rt/refute where required (buster upgrade problem); fixing a couple of jshint mixed tabs and spaces errors; fixing jshint unused variable error
kornelski added a commit that referenced this pull request Apr 14, 2015
Remove built javascript from repo to avoid it getting out of date; link to Browserify CDN for built version
@kornelski kornelski merged commit 7e1f837 into master Apr 14, 2015
@kornelski kornelski deleted the nocompiled branch April 14, 2015 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants