-
Notifications
You must be signed in to change notification settings - Fork 16
Remove built javascript from repo to avoid it getting out of date; link to Browserify CDN for built version #57
Conversation
|
I think the test suite depends on the built version. Also I think we require the |
|
For the test suite I should have solved that with: Weirdly it was coveralls that caused the failed build for this: I'm not sure what you mean by |
| @@ -15,6 +17,7 @@ buster.testCase('View#destroy()', { | |||
|
|
|||
| this.view.destroy(); | |||
|
|
|||
| assert.called(destroy); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This spy didn't appear to have any assertions on it.
|
Jamie @orangemug would you mind having a look at this? |
|
Do we still want to do this following the Bower debacle? |
|
Yes but not yet. I've got it to build with some forks of the dependencies with minimal changes to them (just adding |
|
Pull requests here: |
|
Can we drop support for Bower? |
|
#87 :) |
…rt/refute where required (buster upgrade problem); fixing a couple of jshint mixed tabs and spaces errors; fixing jshint unused variable error
Remove built javascript from repo to avoid it getting out of date; link to Browserify CDN for built version
As discussed here.
Also a bit of spring cleaning:
DONT MERGE YET