Allow callable defaults and verify serializability#181
Open
yuval-p wants to merge 1 commit intofuhrysteve:masterfrom
Open
Allow callable defaults and verify serializability#181yuval-p wants to merge 1 commit intofuhrysteve:masterfrom
yuval-p wants to merge 1 commit intofuhrysteve:masterfrom
Conversation
…value is serializable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checking if the default value is callable is not sufficient, as one can provide a default value that is not callable nor serializable,
uuid.uuid4()for example.this change enables providing callable as a default value and also verifies that the value is serializable