Skip title if either fields are None#93
Open
yeralin wants to merge 5 commits intofuhrysteve:masterfrom
Open
Conversation
2cc2ef8 to
72234a2
Compare
Contributor
Author
|
The build is failing because After a new version is released, the build is supposed to pass. |
72234a2 to
01d42ac
Compare
Contributor
Author
|
Hmmm even after a new release, the build is still failing... I also added an extra test case, but the coveralls are still -1.8% :( |
Contributor
|
Hi @yeralin! The build is failing because of a subtle bug that was introduced in previous PRs. See #102 for details. I'm afraid that we'll have to wait until that PR fixes master, and only then you can rebase your branch and have clean builds. I think that your solution works just fine: it maintains backward compatibility and in my opinion we will need to drop Python 2 support and Marshmallow 2 support very soon anyway. |
01d42ac to
dcf4b47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #87
Because of lack of support of doubly (or more) nested schemas, some
titles get rendered asnullwhich breaks JSON schema validation. This PR simply skipstitleiffield.attributeorfield.nameareNone