Skip to content

fix(validation): handle_one_of uses oneOf instead of enum#95

Open
jgroth wants to merge 1 commit intofuhrysteve:masterfrom
Lundalogik:handle-one-of
Open

fix(validation): handle_one_of uses oneOf instead of enum#95
jgroth wants to merge 1 commit intofuhrysteve:masterfrom
Lundalogik:handle-one-of

Conversation

@jgroth
Copy link

@jgroth jgroth commented Oct 9, 2019

enumNames is not part of the JSON Schema spec, it was part of a draft but was never accepted. It is possible to get the same behaviour using a oneOf property with titles

@coveralls
Copy link

coveralls commented Oct 9, 2019

Coverage Status

Coverage increased (+0.02%) to 99.174% when pulling 0b4d250 on Lundalogik:handle-one-of into c032d1a on fuhrysteve:master.

enumNames is not part of the JSON Schema spec, but it is possible to get the same behaviour using a
oneOf with titles
@jgroth
Copy link
Author

jgroth commented Feb 22, 2021

Ping @fuhrysteve
I have rebased this on master, it would be great to get this merged it's been a PR for a while now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants