modal alert #1723
Draft
modal alert #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujiapple852
force-pushed
the
feat-modal-alert
branch
2 times, most recently
from
091b623 to
74aeccb
Compare
fujiapple852
force-pushed
the
feat-modal-alert
branch
from
74aeccb to
86616d8
Compare
PerchunPak
reviewed
Jan 12, 2026
| .border_type(BorderType::Double); | ||
| let control = Paragraph::new(help_lines) | ||
| .wrap(Wrap::default()) | ||
| .style(Style::default().fg(app.tui_config.theme.help_dialog_text)) |
| .with_height_percentage(0.2) | ||
| .with_placement(DialogPlacement::Centered), | ||
| ); | ||
| f.render_stateful_widget(dialog, f.area(), &mut app.alert_state); |
There was a problem hiding this comment.
I think the modal disappears too quickly, I couldn't read the whole text without spamming the f key. +1 or 2 seconds would be perfect
| de = "Copyright 2022 Trippy Mitwirkende" | ||
|
|
||
| [alert_flows] | ||
| en = "Flows require the udp/dublin or udp/paris ECMP strategy to be enabled" |
There was a problem hiding this comment.
The text seems a bit too technical, maybe add a link to the docs somehow?
https://trippy.rs/guides/recommendation/#udpdublin-with-fixed-target-port-and-variable-source-port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1724