feat: add SupplementaryAlignment constructor from read #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 93.29% 93.33% +0.03%
==========================================
Files 32 32
Lines 3343 3363 +20
Branches 618 619 +1
==========================================
+ Hits 3119 3139 +20
Misses 149 149
Partials 75 75 ☔ View full report in Codecov by Sentry. |
msto
force-pushed
the
ms_supp-aln-constructor
branch
from
db14344 to
f172954
Compare
msto
commented
Jan 31, 2024
Comment on lines
+581
to
+590
| """ | ||
| Construct a list of SupplementaryAlignments from the SA tag in a pysam.AlignedSegment. | ||
|
|
||
| Args: | ||
| read: An alignment. The presence of the "SA" tag is not required. | ||
|
|
||
| Returns: | ||
| A list of all SupplementaryAlignments present in the SA tag. | ||
| If the SA tag is not present, or it is empty, an empty list will be returned. | ||
| """ |
There was a problem hiding this comment.
@nh13 to follow up on our slack convo, I added some detail to the docstring to clarify the behavior when the SA tag is absent.
lmk if you have any suggested edits to the docs before I merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it'd be helpful to abstract away the logic for validating the presence of an SA tag and type-checking, since that's going to be necessary most of the time
parse_sa_tagis used in practice