Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: isort #86

Merged
merged 1 commit into from
Jan 31, 2024
Merged

chore: isort #86

merged 1 commit into from
Jan 31, 2024

Conversation

msto
Copy link
Contributor

@msto msto commented Jan 30, 2024

isort insisted on fixing these when I ran ci/check.sh - afaict I'm using the version specified in the lock file, 5.10.1

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c5d6ff) 93.29% compared to head (b789392) 93.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   93.29%   93.30%           
=======================================
  Files          32       32           
  Lines        3343     3344    +1     
  Branches      618      618           
=======================================
+ Hits         3119     3120    +1     
  Misses        149      149           
  Partials       75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clintval
Copy link
Member

This was probably my mistake. I was relying on poetry and the checks in the GitHub Actions workflow.

Looks like isort isn't wired into GitHub Actions (neither is that CI helper script)...

I'll open an issue to resolve that script vs command in the GH Action.

There are MyPy, Black, and isort plugins for pytest, so I think whoever tackles this should get the harness down to just:

poetry run pytest

And everything can be run underneath that command.

@msto msto merged commit d2578f1 into main Jan 31, 2024
6 checks passed
@clintval clintval deleted the ms_isort branch January 31, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants