Fix canonical-link false positive on root URLs with multi-character TLDs

[Copilot]

The extension check in CanonicalLinkRule ran against the full URL string, causing root URLs like https://webscore.app to be falsely flagged — .app satisfies \.\w+$ even though the pathname has no extension.

Changes

• src/rules/CanonicalLinkRule.ts — Parse href with new URL() and test url.pathname instead of the raw href string. Falls back to testing the full href for relative or unparseable URLs.

// Before
if (/\.\w+$/.test(href)) { ... }

// After
let pathname: string
try {
  pathname = new URL(href).pathname
} catch {
  pathname = href
}
if (/\.\w+$/.test(pathname)) { ... }

• tests/fixtures/CanonicalLinkRule-root-tld.html — New fixture with href="https://webscore.app" (no errors expected).
• tests/fixtures/required-reports.json — Registers the new fixture with an empty error array.

• Fixes bug: canonical-link false positive on root URLs with multi-character TLDs (.app, .io, .dev, etc.) #28

[fulldecent]

@copilot you added a new lockfile and broke sth

that's not how our yarn works

[Copilot]

@copilot you added a new lockfile and broke sth

that's not how our yarn works

Fixed in the latest commit — removed package-lock.json and restored yarn.lock to match main.

[Copilot]

Pull request overview

Fixes a false positive in nice-checkers/canonical-link where root canonical URLs (e.g. https://webscore.app) were incorrectly flagged as “having an extension” by running the extension regex against the full URL string instead of the URL pathname.

Changes:

• Update CanonicalLinkRule to parse href via new URL() and apply the extension check to url.pathname (fallback to raw href when parsing fails).
• Add a new fixture covering a root URL with a multi-character TLD and register it with an empty expected error list.
• Ignore package-lock.json in .gitignore.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/rules/CanonicalLinkRule.ts	Uses parsed URL pathname for the extension check to avoid TLD-based false positives.
tests/fixtures/CanonicalLinkRule-root-tld.html	Adds regression fixture for root canonical URL with .app.
tests/fixtures/required-reports.json	Registers the new fixture with no expected violations.
.gitignore	Ignores package-lock.json.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[fulldecent]

fixed at adb7aa8