Skip to content

fix(packaging): Disable compiling library with ivy#164

Open
AncelHernandez wants to merge 1 commit into
fulls1z3:masterfrom
AncelHernandez:patch-1
Open

fix(packaging): Disable compiling library with ivy#164
AncelHernandez wants to merge 1 commit into
fulls1z3:masterfrom
AncelHernandez:patch-1

Conversation

@AncelHernandez

@AncelHernandez AncelHernandez commented May 28, 2020

Copy link
Copy Markdown

** PR Checklist
Please check if your PR fulfills the following requirements:

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

Issue Number: #163

There is a build error when compiling an application with this library:

ERROR: Error during template compile of 'CoreModule'
  Function calls are not supported in decorators but 'ConfigModule' was called.

** What is the new behavior?
No build error. It is not recomended for libraries to be compiled with ivy yet.

Per the CLI:

It is not recommended to publish Ivy libraries to NPM repositories.
Read more here: https://v9.angular.io/guide/ivy#maintaining-library-compatibility

** Does this PR introduce a breaking change?

[ ] Yes
[ x] No

** Other information

@AncelHernandez AncelHernandez requested a review from fulls1z3 as a code owner May 28, 2020 03:21
@ghost

ghost commented May 28, 2020

Copy link
Copy Markdown

Warnings are found on analyzing the commit a87acc8.

2 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@codecov

codecov Bot commented May 28, 2020

Copy link
Copy Markdown

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files           9        9           
  Lines          91       91           
  Branches       12        9    -3     
=======================================
  Hits           87       87           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5786b9a...a87acc8. Read the comment docs.

@fulls1z3

fulls1z3 commented Jul 8, 2021

Copy link
Copy Markdown
Owner

@AncelHernandez need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

and finally we're showcasing it on fulls1z3/universal#755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants