feat(#1727): add bare-word grep pattern guidance for rename PRs

[fullsend-ai-coder]

The review agent's stale-reference grep used only syntax-specific patterns (e.g., \brepository:) when checking for leftover references after a rename. This missed prose references in documentation files where field names appear without syntax suffixes (e.g., backtick-wrapped repository in markdown).

Add rename/deprecation pattern strategy to the docs-currency sub-agent with guidance to use both a bare-word pattern (\bOLD_NAME\b) and syntax-specific patterns. Add matching guidance to the code-review skill's docs currency dimension for consistency when used outside the pr-review orchestrator.

Note: make lint could not run due to sandbox permission errors (gitleaks Go build). Changes are markdown-only and do not affect Go compilation or tests.

---

Closes #1727

Post-script verification

• Branch is not main/master (agent/1727-broaden-stale-ref-grep)
• Secret scan passed (gitleaks — 809dd645e11aaa889a3355b4220dbe186797dd1c..HEAD)
• Pre-commit hooks passed (authoritative run on runner)
• Tests ran inside sandbox

[github-actions]

Site preview

Preview: https://c1078259-site.fullsend-ai.workers.dev

Commit: 9b3eff8e651c419a8ce314ef380821bef5c1f997

[fullsend-ai-review]

🤖 Review · Started 7:56 PM UTC
Commit: d0ac11b · View workflow run →

[fullsend-ai-review]

Review

Findings

Low

• [cross-reference-availability] internal/scaffold/fullsend-repo/skills/docs-review/SKILL.md:103 — The new text references the docs-currency sub-agent's "Rename/deprecation pattern strategy" section, but docs-currency.md is only loaded into the agent's context when docs-review runs as a sub-agent dispatched by pr-review. When docs-review is invoked standalone, the agent would not have access to docs-currency.md, making the cross-reference a dead pointer. The inline guidance is self-contained enough to be actionable without the cross-reference, so the impact is limited.
  Remediation: Either inline the full strategy directly in docs-review/SKILL.md (removing the cross-reference), or qualify the reference with "when running as a sub-agent of pr-review".

• [documentation-structure] internal/scaffold/fullsend-repo/skills/docs-review/SKILL.md:98 — The "Rename/deprecation PRs" guidance is inserted between the "Write a shell script" instruction and the "Run the script" instruction with its code block, breaking the procedural flow of step 4.
  Remediation: Move this guidance to step 2 ("Build the identifier checklist") where identifier extraction strategies are discussed, or format it as a callout before the script example.

Info

• [design-direction] internal/scaffold/fullsend-repo/skills/docs-review/SKILL.md:103 — The prior review's design-direction finding has been addressed. The docs-review skill now includes a cross-reference to the docs-currency sub-agent's section, establishing the integration point.

• [authorization-confirmed] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/docs-currency.md:23 — The change directly implements the solution proposed in issue Review agent: broaden stale-reference grep patterns for rename/deprecation PRs #1727: adding bare-word grep patterns alongside syntax-specific patterns for rename/deprecation PRs.

• [tier-classification] internal/scaffold/fullsend-repo/skills/code-review/SKILL.md:174 — The PR is classified as feat rather than docs. Both are acceptable — feat emphasizes the new behavioral methodology, docs emphasizes the file type.

Previous run

Review

Findings

Low

• [tier-mismatch] — PR is classified as feat but adds procedural guidance to existing review documentation rather than introducing new capabilities. Since no code changes and only markdown instruction files are modified, docs(#1727): is at least equally defensible as a commit prefix. Either label is reasonable given the change adds a new behavioral methodology.

• [design-direction] internal/scaffold/fullsend-repo/skills/pr-review/sub-agents/docs-currency.md:20 — The new "Rename/deprecation pattern strategy" section is appended to docs-currency.md but is not referenced by docs-review/SKILL.md step 4, where the grep script is constructed. The sub-agent will still see the guidance (it reads its full prompt), so the integration gap is minor. Consider adding a cross-reference in a follow-up.

[fullsend-ai-review]

[low] design-direction

The new Rename/deprecation pattern strategy section is appended to docs-currency.md but is not referenced by docs-review/SKILL.md step 4, where the grep script is constructed. The sub-agent will still see the guidance since it reads its full prompt, so the integration gap is minor.

Suggested fix: Consider adding a cross-reference to the pattern strategy section in docs-review/SKILL.md step 4.

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 7:56 PM UTC · Completed 8:04 PM UTC
Commit: d0ac11b · View workflow run →

[rh-hemartin]

/fs-fix

[fullsend-ai-coder]

🤖 Finished Fix · ✅ Success · Started 8:40 AM UTC · Completed 8:45 AM UTC
Commit: ba204cb · View workflow run →

[fullsend-ai-coder]

🔧 Fix agent — iteration 1 (human-triggered)

Addressed 1 of 2 review findings. Added cross-reference from docs-review/SKILL.md step 4 to the docs-currency sub-agent's rename/deprecation pattern strategy section. Disagreed with tier-mismatch finding as informational and outside fix scope.

Fixed (1):

1. design-direction: missing cross-reference from docs-review step 4 to docs-currency pattern strategy (internal/scaffold/fullsend-repo/skills/docs-review/SKILL.md): Added a rename/deprecation pattern guidance block in docs-review/SKILL.md step 4 with a cross-reference to the docs-currency sub-agent's 'Rename/deprecation pattern strategy' section, ensuring the bare-word pattern approach is discoverable from both entry points.

Disagreed (1):

1. tier-mismatch: PR uses feat prefix but docs prefix may be equally appropriate: The reviewer noted 'either label is reasonable' — this is informational, not a code fix. The original feat prefix is defensible since the change adds a new behavioral methodology (bare-word grep strategy) to the review agents. Changing the PR title prefix is also outside the fix agent's scope (PR mutations are handled by the post-script).

Tests: passed

_{Updated by fullsend fix agent}

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 8:46 AM UTC · Completed 8:59 AM UTC
Commit: ba204cb · View workflow run →