-
Notifications
You must be signed in to change notification settings - Fork 61
docs: sandbox layout, skill precedence, and agent rule layering #2584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+187
−25
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,31 +78,63 @@ your-repo/ | |
| .claude/skills -> ../.agents/skills | ||
| ``` | ||
|
|
||
| ## Skill overloading | ||
| ## Extending agents with repo skills | ||
|
|
||
| Each fullsend agent ships with built-in skills. You can **overload** any of | ||
| these by providing your own skill with the same name. Your version replaces | ||
| the built-in one at runtime — no other configuration needed. | ||
| Skills you add to your repository are available to all fullsend agents | ||
| alongside the built-in skills. This is the primary way to give agents | ||
| domain-specific capabilities — linting rules, deployment checklists, | ||
| architecture constraints — without modifying any fullsend configuration. | ||
|
|
||
| This is the most precise way to tune agent behavior. An overloaded skill is only | ||
| loaded by the agent that uses it, unlike `AGENTS.md` instructions which are | ||
| loaded by every agent. | ||
| Repo skills **extend** the agent's skill set. They do not replace built-in | ||
| skills. If a repo skill has the same name as a built-in skill, the built-in | ||
| version takes precedence and the repo version is silently ignored. Use a | ||
| unique name to ensure your skill is discoverable. | ||
|
Comment on lines
+88
to
+91
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this precedence behavior is accurate, i.e. repo skills with colliding names are silently ignored, then I feel like this should also track a follow-up to log a warning when a repo skill is shadowed, otherwise users have no way to know their skill isn't running. |
||
|
|
||
| ### How overloading works | ||
| ### Skill precedence | ||
|
|
||
| Fullsend uses a layered content resolution model | ||
| ([ADR 0035](../../ADRs/0035-layered-content-resolution.md)). At runtime, the | ||
| agent's workspace is assembled by copying upstream defaults first, then | ||
| overlaying org-level customizations on top. When you provide a skill with the | ||
| same name as a built-in one, yours wins. | ||
| Fullsend uploads built-in skills to the agent's personal-level config | ||
| directory (`CLAUDE_CONFIG_DIR/skills/`). Repo skills live in the project-level | ||
| `.claude/skills/` directory. Claude Code resolves name collisions using | ||
| precedence: | ||
|
|
||
| To overload a skill, create it in your `.fullsend` config repo at | ||
| `customized/skills/<skill-name>/SKILL.md`. The directory name must match the | ||
| built-in skill name exactly. | ||
| ``` | ||
| Personal (CLAUDE_CONFIG_DIR/skills/) > Project (.claude/skills/) | ||
| fullsend built-in skills repo skills | ||
| ``` | ||
|
|
||
| A repo skill with a novel name (no collision) is always available. A repo | ||
| skill with a name matching a built-in skill is shadowed — the agent never | ||
| sees it. | ||
|
|
||
| ### Extension points | ||
|
|
||
| Some agents recognize skill names that do not ship with fullsend. Providing | ||
| these unlocks additional capabilities. See each agent's documentation for the | ||
| skills it supports — for example, the | ||
| [prioritize agent](../../agents/prioritize.md) uses a `customer-research` skill | ||
| when available. | ||
|
|
||
| ## Overriding built-in skills | ||
|
|
||
| To intentionally **replace** a built-in skill with your own version, use the | ||
| `customized/` overlay ([ADR 0035](../../ADRs/0035-layered-content-resolution.md)). | ||
| This replaces the skill at the config layer before the agent starts — the | ||
| built-in version is never uploaded to the sandbox. | ||
|
|
||
| Create the override in your `.fullsend` config repo (per-org mode) or in | ||
| `.fullsend/customized/` in the target repo (per-repo mode). The directory | ||
| name must match the built-in skill name exactly: | ||
|
|
||
| ``` | ||
| customized/skills/code-review/SKILL.md # replaces the built-in code-review | ||
| ``` | ||
|
|
||
| This is an org-sanctioned operation — it goes through the content overlay | ||
| engine, not through project-level skill discovery. | ||
|
|
||
| ### Built-in skills | ||
|
|
||
| These skills ship with fullsend and can be overloaded: | ||
| These skills ship with fullsend and can be overridden via `customized/skills/`: | ||
|
|
||
| | Agent | Skill | Purpose | | ||
| |-------|-------|---------| | ||
|
|
@@ -113,14 +145,6 @@ These skills ship with fullsend and can be overloaded: | |
| | [Prioritize](../../agents/prioritize.md) | `customer-research` | Customer data gathering for RICE scoring (extension point) | | ||
| | [Retro](../../agents/retro.md) | `retro-analysis`, `finding-agent-runs` | Workflow analysis and proposal generation | | ||
|
|
||
| ### Extension points | ||
|
|
||
| Some agents recognize skill names that do not ship with fullsend. Providing | ||
| these unlocks additional capabilities. See each agent's documentation for the | ||
| skills it supports — for example, the | ||
| [prioritize agent](../../agents/prioritize.md) uses a `customer-research` skill | ||
| when available. | ||
|
|
||
| ## When to use skills vs. AGENTS.md | ||
|
|
||
| Use **skills** when you need to change how a specific agent performs a specific | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium] architectural-misalignment
The PR reverses the documented skill precedence model: the old text says repo skills with the same name as built-in skills replace the built-in; the new text says built-in skills take precedence and repo skills are silently ignored. ADR 0035 describes the customized/ overlay mechanism (which the new docs preserve correctly), but the claim about project-level .claude/skills/ being shadowed by personal-level CLAUDE_CONFIG_DIR/skills/ needs verification against Claude Code actual skill resolution behavior.
Suggested fix: Verify Claude Code actual skill precedence (personal > project). If confirmed, add a brief note explaining that this precedence is a Claude Code runtime behavior, distinct from the ADR 0035 overlay mechanism.