-
Notifications
You must be signed in to change notification settings - Fork 61
docs(adr): Agent registration #2755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+539
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| --- | ||
| title: "58. Agent registration" | ||
| status: Accepted | ||
| relates_to: | ||
| - agent-architecture | ||
| - agent-infrastructure | ||
| topics: | ||
| - agents | ||
| - per-repo | ||
| - configuration | ||
| - extensibility | ||
| --- | ||
|
|
||
| # 58. Agent registration | ||
|
|
||
| Date: 2026-06-29 | ||
|
|
||
| ## Status | ||
|
|
||
| Accepted | ||
|
|
||
| ## Context | ||
|
|
||
| Which agents fullsend knows about is currently compiled into the binary. | ||
| Scaffold-embedded harnesses (`internal/scaffold/fullsend-repo/harness/`) | ||
| define the complete agent set, and `HarnessNames()` enumerates them | ||
| from the embed. There is no mechanism for registering agents that live | ||
| outside the scaffold — adding or extracting an agent requires a code | ||
| change to the fullsend binary. | ||
|
|
||
|
ggallen marked this conversation as resolved.
|
||
| The triage agent extraction to `fullsend-ai/agents` | ||
| ([ADR 0045](0045-forge-portable-harness-schema.md) Phase 4) is the | ||
| first agent to move out of the scaffold. The registration mechanism | ||
| must support both first-party extractions and user-defined agents | ||
| without code changes. | ||
|
|
||
| ## Decision | ||
|
|
||
|
ggallen marked this conversation as resolved.
|
||
| Make agent registration a **config-level concept**. Add an `agents` | ||
| list to both `OrgConfig` and `PerRepoConfig`. (Note: ADR 0045 Phase 4 | ||
| previously removed the `agents` block from `OrgConfig`; this re-adds | ||
| a field with the same YAML key but different semantics — harness | ||
| source URLs rather than role/name/slug identity tuples.) Each entry | ||
| is a URL or local path, with an optional name override: | ||
|
ggallen marked this conversation as resolved.
|
||
|
|
||
| ```yaml | ||
| agents: | ||
| - https://raw.githubusercontent.com/fullsend-ai/agents/<sha>/harness/triage.yaml#sha256=<hash> | ||
| - name: lint | ||
| source: harness/my-linter.yaml | ||
| ``` | ||
|
|
||
| `fullsend run <name>` resolves agents from config at runtime, loading | ||
| harnesses directly from URLs or local paths. No intermediate wrapper | ||
| files are generated on disk — role and slug come from the harness | ||
| content itself. Config entries merge additively with | ||
| scaffold-discovered agents; collision is keyed by agent name (explicit | ||
| `name` if set, otherwise derived from source filename) and resolved in | ||
| favor of config, enabling gradual migration. Once all first-party agents are extracted, config | ||
| becomes authoritative and the scaffold fallback is removed. | ||
|
|
||
| A `fullsend agent` CLI subcommand (`add`, `list`, `update`, `remove`) | ||
| manages entries (single-user CLI operations; no concurrency guard on | ||
| config read/write) and auto-pins URLs to a commit SHA with an | ||
| integrity hash. Per-repo config gains `allowed_remote_resources` so per-repo | ||
| installs can validate base composition without an org config repo. | ||
|
ggallen marked this conversation as resolved.
|
||
| Per-repo config is read from the **base branch**, not the PR branch, | ||
| so a PR cannot inject an attacker-controlled `allowed_remote_resources` | ||
| entry or agent source. | ||
|
|
||
| See the [implementation plan](../plans/agent-registration.md) for | ||
| phasing, schema details, CLI behavior, and migration mechanics. | ||
|
|
||
| ## Consequences | ||
|
ggallen marked this conversation as resolved.
|
||
|
|
||
| - Anyone can add an agent to a fullsend installation via `fullsend agent add` — no code change required. | ||
| - First-party and third-party agents follow the same registration path. | ||
| - The additive merge model allows agents to be extracted from the scaffold one at a time without disrupting existing installations. | ||
| - Per-repo installs no longer need org config for remote resource validation. | ||
| - No forced migration — empty config falls back to scaffold discovery until populated. | ||
| - The `agents` YAML key was previously used in `OrgConfig` with a different schema (role/name/slug identity tuples, removed by ADR 0045 Phase 4). The new schema (URL/path source entries) is incompatible; a custom unmarshaler detects and rejects old-format entries with a clear error message. | ||
|
|
||
| ## References | ||
|
|
||
| - [ADR 0033](0033-per-repo-installation-mode.md) -- per-repo installation mode | ||
| - [ADR 0038](0038-universal-harness-access.md) -- URL-based resource references and integrity hashes | ||
| - [ADR 0045](0045-forge-portable-harness-schema.md) -- harness composition via `base:` URLs | ||
| - [ADR 0057](0057-repos-management.md) -- repos management for per-repo installations | ||
| - [Implementation plan](../plans/agent-registration.md) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.