Skip to content

docs(#2802): standardize tier terminology with descriptive prefixes#2885

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/2802-standardize-tier-terminology
Jul 2, 2026
Merged

docs(#2802): standardize tier terminology with descriptive prefixes#2885
rh-hemartin merged 1 commit into
mainfrom
agent/2802-standardize-tier-terminology

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Replace bare "Tier N" references across documentation, ADRs, problem docs, and agent prompts/skills with descriptive-prefix forms to eliminate ambiguity between the three distinct tier systems in this codebase:

  • "credential delivery tier" for the ADR 0025 four-tier credential
    model (tiers 1-4: prefetch, providers, REST server, host files)
  • "intent authorization tier" for the intent-representation.md
    four-tier change authorization model (tiers 0-3: standing rules,
    tactical, strategic, organizational)
  • "configuration tier" for the three-tier config inheritance model
    (upstream defaults, org config, per-repo overrides)

Add a terminology convention entry to AGENTS.md documenting the three tier systems and the requirement to always use a descriptive prefix.

Files updated across 28 docs, ADRs, problem docs, skills, and agent prompts. External tier references (e.g. "GitLab Free tier") are left unchanged. Plan docs with already-contextual "fallback tier" references are also unchanged.

Note: pre-commit and make lint could not run due to sandbox network restrictions preventing shellcheck installation. The post-script runs an authoritative pre-commit check on the runner.


Closes #2802

Post-script verification

  • Branch is not main/master (agent/2802-standardize-tier-terminology)
  • Secret scan passed (gitleaks — 1d4efff9e2d2cdbe2f13e3af03c0dc98a9468f98..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Replace bare "Tier N" references across documentation, ADRs, problem
docs, and agent prompts/skills with descriptive-prefix forms to
eliminate ambiguity between the three distinct tier systems in this
codebase:

- "credential delivery tier" for the ADR 0025 four-tier credential
  model (tiers 1-4: prefetch, providers, REST server, host files)
- "intent authorization tier" for the intent-representation.md
  four-tier change authorization model (tiers 0-3: standing rules,
  tactical, strategic, organizational)
- "configuration tier" for the three-tier config inheritance model
  (upstream defaults, org config, per-repo overrides)

Add a terminology convention entry to AGENTS.md documenting the
three tier systems and the requirement to always use a descriptive
prefix.

Files updated across 28 docs, ADRs, problem docs, skills, and
agent prompts. External tier references (e.g. "GitLab Free tier")
are left unchanged. Plan docs with already-contextual "fallback
tier" references are also unchanged.

Note: pre-commit and make lint could not run due to sandbox
network restrictions preventing shellcheck installation. The
post-script runs an authoritative pre-commit check on the runner.

Closes #2802
@fullsend-ai-coder fullsend-ai-coder Bot requested a review from a team as a code owner July 2, 2026 07:57
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Site preview

Preview: https://164bf90f-site.fullsend-ai.workers.dev

Commit: 2bc52d6bb1b323fa68d590bec6295173f21eaec7

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rh-hemartin rh-hemartin added this pull request to the merge queue Jul 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 2, 2026
@rh-hemartin rh-hemartin added this pull request to the merge queue Jul 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 2, 2026
@rh-hemartin rh-hemartin added this pull request to the merge queue Jul 2, 2026
Merged via the queue into main with commit 98a6eac Jul 2, 2026
16 of 21 checks passed
@rh-hemartin rh-hemartin deleted the agent/2802-standardize-tier-terminology branch July 2, 2026 09:58
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 2, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 10:00 AM UTC · Completed 10:27 AM UTC
Commit: 2bc52d6 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #2885 — Standardize tier terminology

Workflow timeline:

  1. /fs-triage on issue Standardize 'tier' terminology to always use descriptive prefix #2802 → triage agent labeled ready-to-code (3 min)
  2. Code agent created PR docs(#2802): standardize tier terminology with descriptive prefixes #2885 across 28 docs files (+156/−144) in ~19 min
  3. Review agent was not dispatched — the is_event_actor_authorized check rejected the bot actor (already tracked in dispatch: ADR 0054 authorization gate blocks review dispatch for coder-bot PRs #2674)
  4. Human (rh-hemartin) approved ~6 min after PR opened, with no inline comments
  5. PR merged ~2 hours later

Code quality assessment: The code agent correctly identified the three distinct tier systems and accurately classified every reference. However, it applied prefixes mechanically everywhere — producing compound adjectives like "higher-intent-authorization-tier authorization" and repeating "credential delivery tier" 10 times in 5-sentence paragraphs where context was already clear. One semantic error occurred: "compatibility tier" in agent-compatible-code.md was changed to "compatibility classification" even though it was not one of the three defined tier types. Heading renames created new anchor slugs without evidence that all inbound cross-references were verified.

Skipped proposals (already tracked):

Filed proposals: 2 — both target fullsend-ai/fullsend.

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Agent PR ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize 'tier' terminology to always use descriptive prefix

1 participant