Skip to content

chore(deps): update dependency nvidia/openshell to v0.0.116 - #6737

Merged
waynesun09 merged 2 commits into
mainfrom
renovate/openshell
Aug 28, 2026
Merged

chore(deps): update dependency nvidia/openshell to v0.0.116#6737
waynesun09 merged 2 commits into
mainfrom
renovate/openshell

Conversation

@renovate-fullsend

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Update Change
NVIDIA/OpenShell patch 0.0.1150.0.116

Release Notes

NVIDIA/OpenShell (NVIDIA/OpenShell)

v0.0.116: OpenShell v0.0.116

Compare Source

OpenShell v0.0.116
Quick install
curl -LsSf https://raw.githubusercontent.com/NVIDIA/OpenShell/main/install.sh | OPENSHELL_VERSION=v0.0.116 sh
What's Changed

Full Changelog: NVIDIA/OpenShell@v0.0.115...v0.0.116


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate.

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 28, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:21 PM UTC · Completed 7:31 PM UTC

Commit: 094ff79 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.76

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Aug 28, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 28, 2026

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Score unchanged from prior assessment at 2 (moderate). PR now touches 4 files (up from 1 in prior review) but the 3 added files are trivial 1-line version string bumps in docs and hack scripts. Tier 1 remains low (1.38) driven by the single protected path (.github/). Tier 2 is elevated (2.75) due to high churn and fix/revert counts on the docs file, though these reflect routine automated updates rather than instability. Tier 3 confirms the PR directly resolves issue #6707 (broken macOS binaries). Composite 1.81 rounds to 2 (moderate).

Previous run

Risk Assessment: moderate (2/5)

Details

Trivial 4-line version bump by Renovate bot in a single script file (.github/scripts/openshell-version.sh). Tier 1 is very low (1.25) driven only by the protected path (.github/). Tier 2 is elevated (2.75) due to multi-author contention and fix/revert history on this file, though these reflect routine automated version bumps rather than true instability. Composite 1.82 rounds to 2 (moderate).

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review

Findings

Medium

Previous run

Review

Findings

High

  • [protected-path] .github/scripts/openshell-version.sh — This PR modifies a file under the .github/ protected path. The PR has no linked issue providing authorization for modifying governance/infrastructure files. While this is an automated Renovate dependency version bump (OpenShell 0.0.115 → 0.0.116) and the file itself documents that it is managed by Renovate via renovate.json with postUpgradeTasks, human approval is required for all protected-path changes.
    Remediation: A human reviewer must approve this protected-path change. No code changes are needed.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

Renovate only tracks .github/scripts/openshell-version.sh. The runner VM
fallbacks in hack/gitlab-runner-vm/{create-vm,setup}.sh and the install
snippet in docs/guides/user/running-agents-locally.md carry the same
version by hand and were left at 0.0.115, so move them together with the
pin as #6696 did.

The docs snippet matters beyond consistency: 0.0.115's Apple Silicon
binaries were linked against a Nix store libiconv and could not start
(NVIDIA/OpenShell#2997), and the guide pointed macOS users at exactly
that build. 0.0.116 ships the upstream fix (NVIDIA/OpenShell#3006), so
pointing the guide at it resolves the macOS install path.

Closes #6707

Assisted-by: Claude
Signed-off-by: Wayne Sun <gsun@redhat.com>
@waynesun09

Copy link
Copy Markdown
Member

Added 5932b2f2 on top of the Renovate commit: Renovate only tracks .github/scripts/openshell-version.sh, so the hand-maintained mirrors — the OPENSHELL_VERSION fallbacks in hack/gitlab-runner-vm/{create-vm,setup}.sh and the install snippet in docs/guides/user/running-agents-locally.md — were still at 0.0.115. Moved them together with the pin, as #6696 did.

The docs line is the one that matters: 0.0.115's Apple Silicon binaries could not start (NVIDIA/OpenShell#2997, fixed upstream in NVIDIA/OpenShell#3006 and shipped in 0.0.116), and the guide pointed macOS users at that build. The commit carries Closes #6707 for that. Verified the 0.0.116 darwin CLI and gateway tarballs run unpatched (0 /nix/store refs).

Note for Renovate: a non-bot commit is now on this branch, so it will stop rebasing it automatically; tick the rebase checkbox only if you want to discard the extra commit.

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 28, 2026

Copy link
Copy Markdown

🤖 Review · ❌ Terminated · Started 8:07 PM UTC · Ended 8:21 PM UTC

Commit: 5932b2f · View workflow run →

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://1112319a-site.fullsend-ai.workers.dev

Commit: 5932b2f2a8a4b6e0ae8b5f2a07b92b92b1e6bd8e

@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review August 28, 2026 20:21

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 28, 2026
@fullsend-ai-review

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:07 PM UTC · Completed 8:21 PM UTC

Commit: 5932b2f · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.59

@waynesun09 waynesun09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renovate pin bump to OpenShell 0.0.116 plus the hand-maintained mirrors (runner VM fallbacks, local-run guide) moved in the same PR. OPENSHELL_SHA matches the v0.0.116 tag commit. v0.0.115→v0.0.116 contains only the macOS binary normalization (NVIDIA/OpenShell#3006), a shutdown log reclassification, and test/dev-script changes — nothing in the proxy, providers, or sandbox lifecycle. CI on this head installed 0.0.116 and passed functional-tests (4/4), e2e, and behaviour.

@waynesun09
waynesun09 added this pull request to the merge queue Aug 28, 2026
Merged via the queue into main with commit 5b79665 Aug 28, 2026
55 checks passed
@waynesun09
waynesun09 deleted the renovate/openshell branch August 28, 2026 20:39
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 28, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 8:41 PM UTC · Completed 9:00 PM UTC

Commit: 5932b2f · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $7.19

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #6737 — OpenShell dependency bump (0.0.115 → 0.0.116)

Workflow summary: Renovate opened a 1-file version bump. The review agent flagged .github/scripts/openshell-version.sh as a protected path (HIGH, no linked issue) and requested changes. The fix agent correctly skipped (bot author without fullsend-fix label). A human (waynesun09) pushed a second commit updating 3 hand-maintained version mirrors and linking issue #6707 (macOS Apple Silicon binary breakage). The review agent re-ran, downgraded the finding to MEDIUM, and dismissed the stale REQUEST_CHANGES review. The human approved and merged. Total review agent cost: $5.35 across two runs (7m26s + 11m29s).

Verdict: workflow functioned correctly. The protected-path gate worked as designed — it surfaced a governance-relevant file change, a human reviewed and approved it, and the PR merged with all CI checks passing. No bugs, no missed findings, no false negatives.

No new proposals filed. All improvement opportunities identified are already covered by existing open issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant