Skip to content

Remove excessive UIApplication.shared.open calls. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fumito-ito merged 1 commit into from
Nov 6, 2025
Merged

Remove excessive UIApplication.shared.open calls. #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Sources/SwiftyInAppMessaging/Default/Banner/InAppDefaultBannerMessageViewControlller.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@
actionText: self?.title, actionURL: self?.actionURL)
self?.eventDetector.messageClicked(with: action)
})

UIApplication.shared.open(url, options: [:], completionHandler: nil)
}
}

Expand Down
10 changes: 0 additions & 10 deletions Sources/SwiftyInAppMessaging/Default/Card/InAppDefaultCardMessageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,22 +175,12 @@

extension InAppDefaultCardMessageViewController: InAppDefaultCardMessageViewDelegate {
public func primaryActionButtonDidTap() {

if let actionURL = self.primaryActionURL, UIApplication.shared.canOpenURL(actionURL) {
UIApplication.shared.open(actionURL, options: [:], completionHandler: nil)
}

let action = InAppMessagingAction(
actionText: self.primaryActionButtonText, actionURL: self.primaryActionURL)
eventDetector.messageClicked(with: action)
}

public func secondaryActionButtonDidTap() {

if let actionURL = self.secondaryActionURL, UIApplication.shared.canOpenURL(actionURL) {
UIApplication.shared.open(actionURL, options: [:], completionHandler: nil)
}

let action = InAppMessagingAction(
actionText: self.secondaryActionButtonText, actionURL: self.secondaryActionURL)
eventDetector.messageClicked(with: action)
Expand Down
4 changes: 0 additions & 4 deletions ...s/SwiftyInAppMessaging/Default/ImageOnly/InAppDefaultImageOnlyMessageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@

extension InAppDefaultImageOnlyMessageViewController: InAppDefaultImageOnlyViewDelegate {
public func imageDidTap() {
if let actionURL = self.actionURL, UIApplication.shared.canOpenURL(actionURL) {
UIApplication.shared.open(actionURL, options: [:], completionHandler: nil)
}

let action = InAppMessagingAction(actionText: nil, actionURL: self.actionURL)
eventDetector.messageClicked(with: action)
}
Expand Down
5 changes: 0 additions & 5 deletions Sources/SwiftyInAppMessaging/Default/Modal/InAppDefaultModalMessageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,6 @@

extension InAppDefaultModalMessageViewController: InAppDefaultModalViewDelegate {
public func actionButtonDidTap() {

if let actionURL = self.actionURL, UIApplication.shared.canOpenURL(actionURL) {
UIApplication.shared.open(actionURL, options: [:], completionHandler: nil)
}

let action = InAppMessagingAction(
actionText: self.actionButtonText, actionURL: self.actionURL)
eventDetector.messageClicked(with: action)
Expand Down