Skip to content

科目検索結果の表示にListItemコンポーネントを使用する。#24

Merged
T-shinku0314 merged 2 commits into
mainfrom
feature/subjects-list-item
Jul 18, 2026
Merged

科目検索結果の表示にListItemコンポーネントを使用する。#24
T-shinku0314 merged 2 commits into
mainfrom
feature/subjects-list-item

Conversation

@T-shinku0314

@T-shinku0314 T-shinku0314 commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

やったこと

  • 科目検索結果の各アイテムの表示を、インラインで書いていたJSXから ListItem コンポーネントに置き換えました
  • title に科目名、descriptions に学期・曜日時限・単位・担当教員を渡しています。

@T-shinku0314
T-shinku0314 requested a review from kantacky July 18, 2026 03:53
@T-shinku0314 T-shinku0314 self-assigned this Jul 18, 2026
@T-shinku0314
T-shinku0314 requested review from a team, hikaru-0602 and masaya-osuga July 18, 2026 03:53
kantacky
kantacky reviewed Jul 18, 2026
View reviewed changes
Comment thread src/app/subjects/SubjectsSearchView.tsx
@T-shinku0314
T-shinku0314 added this pull request to the merge queue Jul 18, 2026
Merged via the queue into main with commit 1ef6465 Jul 18, 2026
3 checks passed
@T-shinku0314
T-shinku0314 deleted the feature/subjects-list-item branch July 18, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kantacky kantacky kantacky approved these changes
@hikaru-0602 hikaru-0602 Awaiting requested review from hikaru-0602 hikaru-0602 was automatically assigned from fun-dotto/masters
@masaya-osuga masaya-osuga Awaiting requested review from masaya-osuga masaya-osuga was automatically assigned from fun-dotto/masters

Assignees

@T-shinku0314 T-shinku0314

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@T-shinku0314 @kantacky