Hospitality Director

[pirakaplant]

About the PR

This PR adds onto #263, #280, #287, and #294 to fully implement Hospitality Director in the game! YAY! Essentially:

• HD has proper clothing options, loadout, chameleon outfit, etc. All the new clothes can be seen in the Media section, can be made in a uniform printer, and were sprited by @Chedd-Error (a.k.a. zergologist).
• HD has a proper prototype for their dresser, which contains most of the clothes they have access to in the loadout.
• HD has role timers more in line with what we want on Forky (15h Service, 5h Bartender, 5h Chef) (see Funky Role Timer/Job Weight Parity #236).
• HD spawns with a flash like all other Command jobs.
• HD has a proper sprite for its job spawner (this won't be noticeable unless you're a mapper).

Why / Balance

See funky-station/docs#96 for the overall vision. In addition, there are a few reasons the time requirements this PR introduces were picked:

• The HD is a Command role, but requires less mechanical knowledge to play than a role like RD or CE. It's roughly comparable to QM, so it gets a flat 20 hour department requirement too.
• The HD's forte is in catering, and Bartender and Chef are the two most mechanically deep roles in the Service department (with the rest of the department being "roleplay" jobs). These are the only two jobs under the HD that really need "teaching" in that capacity too. Therefore, the HD should have some experience in both of them.

Technical details

Just YAML and FTL. Some notes:

• hospitalitydirector.yml was changed to hospitality_director.yml for consistency with other job YAML files.
• I adopted a slightly different method of organising _Funkystation/Recipes/Lathes/clothing.yml compared to its non-_Funkystation equivalent. The upstream version is a bit weird and inconsistent and I think my way of organising things is clearer enough to justify deviating from the standard that Wizard's Den set.

Test plan

1. Create a new release build of the game to make sure previous playtime in your development environment hasn't carried over.
2. Go to the customisation menu and make sure the following is true:
   2a. The time requirements for Hospitality Director match what's described in this PR.
   2b. The loadout options for Hospitality Director all work correctly.
3. Disable time requirements, set the map to Packed, and join the round as a Hospitality Director. Make sure you correctly spawn with the loadout, including your flash.
4. Enable Show Spawns and use the sandbox menu to spawn in a Hospitality Director job spawner. It should have the new texture shown in Media.
5. Spawn and equip the contents of the chameleon outfit backpack. Inject the chameleon controller implant. Make sure that setting it to Hospitality Director gives you the chameleon outfit shown in Media.

Media

(The job spawner.)

(The contents of the Hospitality Director's dresser.)

(The chameleon outfit.)

Requirements

• I have read and am following the Macrocosm Pull Request Conventions.
• I have tested this pull request and written instructions on how to test it
• I have added media to this PR or it does not require an in-game showcase.
• If I am porting something, I have done my best to respect the appropriate licenses associated with the presented changes.

License

MIT

Breaking changes

If you're not adding the Hospitality Director from #280, just revert this PR.

Changelog

🆑 pirakaplant, zergologist

• add: Added the hospitality director's pillbox hat, two hospitality director's uniforms, plus a hospitality director's vest, coat, and winter coat (sprites by zergologist). They can all be made in a uniform printer.
• tweak: Changed the Hospitality Director's loadout options to fit the new clothing items.
• tweak: Updated the Hospitality Director chameleon outfit to better fit their new loadout.
• tweak: Increased the Hospitality Director's hour requirements to 15 Service hours, 5 Bartender hours, and 5 Chef hours.
• tweak: The Hospitality Director now starts with a flash.
• tweak: Updated the Hospitality Director job spawn icon.

[github-actions]

RSI Diff Bot; head commit d9a6366 merging into 376b5ab
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Funkystation/Clothing/Head/Hats/hd.rsi

State	Old	New	Status
equipped-HELMET			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Funkystation/Clothing/OuterClothing/Coats/hd.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Funkystation/Clothing/OuterClothing/Vests/hd.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Funkystation/Clothing/OuterClothing/Wintercoats/NoHood/hd.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Funkystation/Clothing/Uniforms/Service/TwoPiecePants/hd.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Funkystation/Clothing/Uniforms/Service/TwoPieceSkirt/hd.rsi

State	Old	New	Status
equipped-INNERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_Funkystation/Markers/jobs.rsi

State	Old	New	Status
green			Added
hd			Added

Edit: diff updated after d9a6366

[Chedd-Error]

just put my name as zergologist in the changelog, no need for "Chedd-Error"

[pirakaplant]

@Chedd-Error

just put my name as zergologist in the changelog, no need for "Chedd-Error"

Done

[TheSecondLord]

Bartender and Chef are the two most mechanically deep roles in the Service department (with the rest of the department being "roleplay" jobs)

Did you forget that botany exists? (botany still exists right??)

Also, there's already so much red clothing. Security is red, syndicate is red, new players are going to see this and think it's the HoS. Can't the clothing colour scheme be bright/pale green?

[Maestro-Kimpembe]

Welcome back The Doorman from Deadlock.

[Teasq]

Bartender and Chef are the two most mechanically deep roles in the Service department (with the rest of the department being "roleplay" jobs)

Did you forget that botany exists? (botany still exists right??)

Also, there's already so much red clothing. Security is red, syndicate is red, new players are going to see this and think it's the HoS. Can't the clothing colour scheme be bright/pale green?

Botany isn't a part of service anymore. Like, confirmed. The changes have been merged and they're under cargo (now logistics).
Additionally, I'd like to add that I don't care about colour coding shit where it doesn't matter. The end goal for me is to make sprites more readable overall and not rely simply on colour to identify things. Not my PR, but I can give you the reasoning behind the HD not just being service green.

[TheSecondLord]

Botany isn't a part of service anymore. Like, confirmed. The changes have been merged and they're under cargo (now logistics).

sure why not

Not my PR, but I can give you the reasoning behind the HD not just being service green

You're welcome to share it. To clarify, it doesn't have to be green, that was just the most obvious colour to suggest but I also don't care about forcing department clothing to match a colour scheme. My point was that formal red with gold accents is a very much occupied design scheme.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[YaraaraY]

get merge conflicts sorted and it's good to go

[pirakaplant]

Test fail not related. Going to merge as soon as I write up a thing for #downstream-announcements concerning this and #264.