Allow create_text to accept multiple texts and materials fixes #1012 by AdityaGupta716 · Pull Request #1101 · fury-gl/fury

AdityaGupta716 · 2026-02-21T10:17:07Z

Changes

Updated create_text in fury/actor/core.py to accept a list of
strings and a list of materials
Returns a single Text actor for a string (backward compatible)
Returns a Group of Text actors for a list of strings
Added tests in fury/actor/tests/test_actor_text.py

Usage

# Single text (unchanged behavior)
t = create_text("Hello", material)

# Multiple texts
t = create_text(["Hello", "World", "FURY"], material)

# Multiple texts with individual materials
t = create_text(["Hello", "World"], [material1, material2])

AdityaGupta716 · 2026-02-21T11:11:11Z

@maharshi-gor I've implemented the changes for this issue. Plz review

maharshi-gor · 2026-02-25T16:45:16Z

fury/actor/core.py

+        The material object or list of material objects.
    **kwargs : dict
        Additional properties like font_size, anchor, etc.



Please also think about how do you provide all the other keyword arguments in the case of multiple text?

Will the position be same for all of them?

maharshi-gor · 2026-02-25T16:45:37Z

Hi @AdityaGupta716 thanks for the work. Please take a look at the repository structure before submitting a PR.
The text actor testcases are present in actor\tests\test_core.py where the new tests should also reside.

Updated create_text function to support per-text customization for materials and additional kwargs.

…t validation

AdityaGupta716 · 2026-02-25T19:35:31Z

@maharshi-gor, the kwargs are fully flexible — pass a single value and it broadcasts to all text objects, or pass a list for per-text control. For example font_size=24 applies to all, while position=[(0,0,0), (1,0,0)] sets each independently. Length mismatches raise a ValueError immediately. Let me know if you need anything else.

maharshi-gor

As I suspect the PR needs to update different file and add the test cases at different location according to that.

maharshi-gor · 2026-02-26T16:32:48Z

fury/actor/core.py

+    >>> # Multiple texts, shared material and kwargs
+    >>> t = create_text(["Hello", "World", "FURY"], mat)
+
+    >>> # Multiple texts with individual materials and per-text positions


Remove comments from examples.

maharshi-gor · 2026-02-26T16:38:15Z

fury/actor/core.py

 def create_text(text, material, **kwargs):
-    """Create a text object.
+    """Create a text object or a group of text objects.

    Parameters
    ----------
-    text : str
-        The text content.
-    material : TextMaterial
-        The material object.
+    text : str or list of str
+        The text content or list of text contents.
+    material : TextMaterial or list of TextMaterial
+        The material object or list of material objects.
    **kwargs : dict
-        Additional properties like font_size, anchor, etc.
+        Additional properties like font_size, anchor, position, etc.
+        When ``text`` is a list, each kwarg can be either:
+        - A single value applied to all text objects, or
+        - A list of values (one per text) for per-text customization.

    Returns
    -------
-    Text
-        The text object.
+    Text or Group
+        A single Text object if text is a string, or a Group of Text
+        objects if text is a list.

    Raises
    ------
    TypeError
-        If text is not a string or material is not an instance of TextMaterial.
+        If text is not a string or list of strings, or material is not
+        an instance of TextMaterial or list of TextMaterial.
+    ValueError
+        If the length of material list or any kwarg list does not match
+        the length of the text list.
+
+    Examples
+    --------
+    >>> mat = TextMaterial()
+    >>> # Single text (unchanged behavior)
+    >>> t = create_text("Hello", mat)
+
+    >>> # Multiple texts, shared material and kwargs
+    >>> t = create_text(["Hello", "World", "FURY"], mat)
+
+    >>> # Multiple texts with individual materials and per-text positions
+    >>> t = create_text(
+    ...     ["Hello", "World"],
+    ...     [TextMaterial(), TextMaterial()],
+    ...     position=[(0, 0, 0), (1, 0, 0)],
+    ... )
    """
+    if isinstance(text, list):
+        if not all(isinstance(t, str) for t in text):
+            raise TypeError("All items in text list must be strings.")
+
+        n = len(text)
+
+        if isinstance(material, list):
+            if len(material) != n:
+                raise ValueError(
+                    "Length of material list must match length of text list."
+                )
+            if not all(isinstance(m, TextMaterial) for m in material):
+                raise TypeError(
+                    "All items in material list must be instances of TextMaterial."
+                )
+            materials = material
+        else:
+            if not isinstance(material, TextMaterial):
+                raise TypeError("material must be an instance of TextMaterial.")
+            materials = [material] * n
+
+        # Normalize kwargs: expand scalars to per-text lists
+        norm_kwargs = {}
+        for k, v in kwargs.items():
+            if isinstance(v, list):
+                if len(v) != n:
+                    raise ValueError(
+                        f"Length of kwarg '{k}' list must match length of text list."
+                    )
+                norm_kwargs[k] = v
+            else:
+                norm_kwargs[k] = [v] * n
+
+        group = Group()
+        for i, (t, m) in enumerate(zip(text, materials, strict=True)):
+            per_text_kwargs = {k: norm_kwargs[k][i] for k in norm_kwargs}
+            position = per_text_kwargs.pop("position", None)
+            actor = Text(text=t, material=m, **per_text_kwargs)
+            if position is not None:
+                actor.local.position = position
+            group.add(actor)
+        return group
+
    if not isinstance(text, str):
        raise TypeError("text must be a string.")

    if not isinstance(material, TextMaterial):
        raise TypeError("material must be an instance of TextMaterial.")

-    text = Text(text=text, material=material, **kwargs)
-    return text
+    return Text(text=text, material=material, **kwargs)


I feel this should not be done here. Please check the text method in the planar.py

fury/fury/actor/planar.py

Line 497 in 8bb525c

def text(

This method should be updated to accept multiple text not this method. The text method is the one which people should use.

AdityaGupta716 added 6 commits February 21, 2026 15:39

Update core.py

07aa68a

Create test_actor_text.py

e67cd6f

Fix pre-commit formatting

6222c44

Remove accidental .save file

c97f3d8

Update core.py

dbd6206

Update core.py

8ed4b87

maharshi-gor reviewed Feb 25, 2026

View reviewed changes

maharshi-gor requested changes Feb 25, 2026

View reviewed changes

AdityaGupta716 added 10 commits February 25, 2026 22:28

Enhance create_text for multiple texts and kwargs

4b51fa2

Updated create_text function to support per-text customization for materials and additional kwargs.

Add create_text function for text object creation

2eb8b9b

Fix create_text: per-text kwargs support, move tests to test_core.py

39d166e

Fix pre-commit: strict zip, mixed line endings

f8f2635

Fix Text class to accept position kwarg

fbc73c8

Fix Text.__init__ docstring and parameter docs

051b313

Fix Text class docstring for numpydoc validation

7fd2c98

Fix Text.__init__ to have optional text and material args

c2bee3f

Handle position in create_text instead of Text.__init__

b77ab86

Fix create_text: remove duplicate norm_kwargs block, add material lis…

a1d469d

…t validation

AdityaGupta716 requested a review from maharshi-gor February 25, 2026 19:35

maharshi-gor requested changes Feb 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow create_text to accept multiple texts and materials fixes #1012#1101

Allow create_text to accept multiple texts and materials fixes #1012#1101
AdityaGupta716 wants to merge 16 commits intofury-gl:v2from
AdityaGupta716:text-3d-multi

AdityaGupta716 commented Feb 21, 2026

Uh oh!

AdityaGupta716 commented Feb 21, 2026 •

edited

Loading

Uh oh!

maharshi-gor Feb 25, 2026

Uh oh!

maharshi-gor commented Feb 25, 2026

Uh oh!

AdityaGupta716 commented Feb 25, 2026

Uh oh!

maharshi-gor left a comment

Uh oh!

maharshi-gor Feb 26, 2026

Uh oh!

maharshi-gor Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AdityaGupta716 commented Feb 21, 2026

Changes

Usage

Uh oh!

AdityaGupta716 commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maharshi-gor Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

maharshi-gor commented Feb 25, 2026

Uh oh!

AdityaGupta716 commented Feb 25, 2026

Uh oh!

maharshi-gor left a comment

Choose a reason for hiding this comment

Uh oh!

maharshi-gor Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

maharshi-gor Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AdityaGupta716 commented Feb 21, 2026 •

edited

Loading