Merged
Conversation
ganimtron-10
force-pushed
the
v2_slider
branch
2 times, most recently
from
753d6a8 to
502bc64
Compare
ganimtron-10
force-pushed
the
v2_slider
branch
from
502bc64 to
3849da1
Compare
feat: adding LineSlider2D fix: vertical slider not working fix: ratio calculation and handle positioning fix: docs and import chore: adding tests for line slider
ganimtron-10
force-pushed
the
v2_slider
branch
from
3849da1 to
b1a935a
Compare
Contributor
|
Hi @ganimtron-10 Thanks for the work. LGTM! Just confirming on the test cases please delete in the other PR that mentioned. #1056 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding LineSlider2D UI Component