Fix ImageContainer2D for Fury v2: wrap image in UI and handle RGB images#1138
Open
VanshAgarwal24036 wants to merge 1 commit intofury-gl:masterfrom
Open
Fix ImageContainer2D for Fury v2: wrap image in UI and handle RGB images#1138VanshAgarwal24036 wants to merge 1 commit intofury-gl:masterfrom
VanshAgarwal24036 wants to merge 1 commit intofury-gl:masterfrom
Conversation
31f24f1 to
f7d396d
Compare
Author
|
Hi maintainers All tests and ruff checks pass locally. Thank you! |
Author
|
@maharshi-gor @ganimtron-10 plz review |
Contributor
|
Hi @VanshAgarwal24036 , thanks for this PR, but, we are currently develpoing the v2 branch not the master branch, and given there is no conflicts with master I don't think is is based on v2, please always start your branch based on v2 branch not master. |
Author
|
Thankyou @m-agour I will review again and do changes accordingly to v2 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes and ports
ImageContainer2Dto work properly with the current Fury v2 architecture.Fixes #1108
This PR:
_ImageUIclass that properly subclassesUI._update_actors_positionmethod.ImageContainer2D.