This repository was archived by the owner on May 17, 2019. It is now read-only.
decrease import/no-named-as-default rule level from error to warn #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale, I have a component `Button`, looks like this:
```js
// ...
export class Button extends Component {
// ...
}
export default styled(Button);
```
Except for tests, I 100% of the time do `import Button from 'path/to/my/button'`
With the level for the `import/no-named-as-default` set to `'error'`, I have to do something like `import StyledButon from 'path/to/my/button'`
setting the rule level to "warn" instead of "error" WARNS the user in case they were supposed to import the named export, but if you know that you want the default, you can safely ignore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale, I have a component
Button, looks like this:Except for tests, I 100% of the time do
import Button from 'path/to/my/button'With the level for the
import/no-named-as-defaultset to'error', I have to do something likeimport StyledButon from 'path/to/my/button'setting the rule level to "warn" instead of "error" WARNS the user in case they were supposed to import the named export, but if you know that you want the default, you can safely ignore