Add support for multiple packages for RAPL sensor #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patgruber
changed the title
fvaleye
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Thank you, @patricgruber, for reporting the issue and providing a fix 🙏
LGTM 👍
Indeed, overriding the core and dram values in the dictionary was an issue when there were multiple packages.
I will include your fix in the next release.
Don't hesitate to check the values after again.
|
Thank you! I will try the new release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue of having wrong results on servers with multiple CPUs as described in #391
Related Issue(s)
Documentation
The fix is to prefix the name with the "id" of the package, which is taken from the parent directory name of the file. This won't cause issues with summing up values for the report, since it uses checks like
"package" in result.name, but it fixes the issue with the computation of the differences, that confuse the values ofcpu,dramand so on of different CPUs for being from the same CPU.