Skip to content

fix: 🐛 Use prosemirror for text-editor instead of tinymce #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Stefouch wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: 🐛 Use prosemirror for text-editor instead of tinymce #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3352be
build: 📦️ Update packages
Stefouch Jul 7, 2025
9e76750
fix: 🐛 Use prosemirror for text-editor instead of tinymce
Stefouch Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,156 changes: 1,074 additions & 82 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"yzur": "github:Stefouch/foundry-year-zero-roller#v6.0.0"
},
"devDependencies": {
"@league-of-foundry-developers/foundry-vtt-types": "^12.331.5",
"@league-of-foundry-developers/foundry-vtt-types": "^13.345.1",
"@types/jquery": "^3.5.32",
"@typhonjs-fvtt/eslint-config-foundry.js": "0.8.0",
"chalk": "^5.3.0",
Expand All @@ -69,8 +69,8 @@
"gulp": "^4.0.2",
"gulp-yaml": "2.0.4",
"husky": "^8.0.3",
"prettier": "^3.5.3",
"prettier": "^3.6.2",
"prettier-eslint-cli": "^8.0.1",
"semver": "^7.5.4"
}
}
}
2 changes: 1 addition & 1 deletion src/actor/character/templates/character-limited-sheet.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
</div>

<div class="sheet-body">
{{{editor system.description target="system.description" button=true editable=editable}}}
{{{editor system.description target="system.description" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>

</form>
2 changes: 1 addition & 1 deletion src/actor/character/templates/character-sheet.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
{{> systems/blade-runner/templates/actor/character/sheet-tabs/bio-tab.hbs}}
{{else if isNPC}}
<div class="boxed-property npc-notes">
{{{editor system.description target="system.description" button=true editable=editable}}}
{{{editor system.description target="system.description" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>
{{/if}}
</div>
Expand Down
10 changes: 5 additions & 5 deletions src/actor/character/templates/sheet-tabs/bio-tab.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="boxed-property bio-notes">
<h3>{{localize "FLBR.HEADER.Notes"}}</h3>
<div class="bio-editor">
{{{editor system.description target="system.description" button=true editable=editable}}}
{{{editor system.description target="system.description" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>
</div>
{{#if system.bio}}
Expand All @@ -13,25 +13,25 @@
<div class="boxed-property">
<h3>{{localize "FLBR.HEADER.Appearance"}}</h3>
<div class="bio-editor">
{{{editor system.bio.appearance target="system.bio.appearance" button=true editable=editable}}}
{{{editor system.bio.appearance target="system.bio.appearance" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>
</div>
<div class="boxed-property">
<h3>{{localize "FLBR.HEADER.Home"}}</h3>
<div class="bio-editor">
{{{editor system.bio.home target="system.bio.home" button=true editable=editable}}}
{{{editor system.bio.home target="system.bio.home" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>
</div>
<div class="boxed-property">
<h3>{{localize "FLBR.HEADER.KeyMemory"}}</h3>
<div class="bio-editor">
{{{editor system.bio.keyMemory target="system.bio.keyMemory" button=true editable=editable}}}
{{{editor system.bio.keyMemory target="system.bio.keyMemory" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>
</div>
<div class="boxed-property">
<h3>{{localize "FLBR.HEADER.KeyRelationship"}}</h3>
<div class="bio-editor">
{{{editor system.bio.keyRelationship target="system.bio.keyRelationship" button=true editable=editable}}}
{{{editor system.bio.keyRelationship target="system.bio.keyRelationship" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>
</div>
{{/if}}
Expand Down
2 changes: 1 addition & 1 deletion src/actor/loot/templates/loot-sheet.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="loot-notes boxed-property">
<h3>{{localize "FLBR.HEADER.Notes"}}</h3>
<div>
{{{editor system.description target="system.description" button=true editable=editable}}}
{{{editor system.description target="system.description" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion src/actor/vehicle/templates/vehicle-sheet.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@

<div class="tab" data-group="primary" data-tab="bio">
<div class="boxed-property">
{{{editor system.description target="system.description" button=true editable=editable}}}
{{{editor system.description target="system.description" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion src/item/templates/item-sheet.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<div class="sheet-body">

<div class="tab tab-info" data-group="primary" data-tab="info">
{{{editor system.description target="system.description" button=true editable=editable}}}
{{{editor system.description target="system.description" button=true editable=editable engine="prosemirror" collaborate=false}}}
</div>

<div class="tab tab-features" data-group="primary" data-tab="features">
Expand Down