Improve URI Parsing - #582
Open
vladaviedov wants to merge 1 commit into
Open
Conversation
fwcd
reviewed
Jun 27, 2024
fwcd
left a comment
fwcd
left a comment
Owner
There was a problem hiding this comment.
Thanks, I'll take a closer look once I find some time. Just a quick note below
|
|
||
| fun URI.toKlsURI(): KlsURI? = when (scheme) { | ||
| "kls" -> KlsURI(URI("kls:${schemeSpecificPart.replace(" ", "%20")}")) | ||
| "kls" -> KlsURI(URI("kls:${schemeSpecificPart}")) |
Owner
There was a problem hiding this comment.
We'll have to be extra careful here though not to regress any popular client (including VSCode on all major platforms). I remember URL encoding being a tricky subject since different clients often handle percent encodings in subtly different ways.
Author
There was a problem hiding this comment.
Might Windows drive letters be the issue? It's the only part of the spec that seems to mention URI inconsistencies.
mScott224
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go to Definition throws an exception when a JAR contains a plus sign in its name (as described in #326).
parseURIcallsURLDecoder.decodeon its input, but if the input is not encoded, it converts the plus to a space.I tried to remove the decoding and properly encode the file path for later usage, which seems to be working for me in both neovim and vscode, but I have no idea how to test the "invalid percent encoding for colons".