Add override soft keyword as simple identifier #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also modifies the precedence of modifiers to be prec.right instead of prec.left since we want to parse all the modifiers and not only the ones that don't conflict. For instance, `final override` modifiers should both be parsed as modifiers and not just `final` as a modifier and `override` as a simple_identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also modifies the precedence of modifiers to be prec.right instead of prec.left since we want to parse all the modifiers and not only the ones that don't conflict. For instance,
final overridemodifiers should both be parsed as modifiers and not justfinalas a modifier andoverrideas a simple_identifier.