Remove suspend from builtin functions - it's a modifier keyword #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrosAlexiou
changed the title
AlexandrosAlexiou
force-pushed
the
fix/suspend-highlighting
branch
from
948d5d8 to
bde5e43
Compare
Fixes fwcd#197 The 'suspend' keyword is a function modifier in Kotlin used to mark suspending functions for coroutines. It should not be highlighted as a builtin function like println() or arrayOf(). This change removes 'suspend' from the @function.builtin list in the highlights query, allowing it to be correctly highlighted as a keyword modifier instead.
AlexandrosAlexiou
force-pushed
the
fix/suspend-highlighting
branch
from
bde5e43 to
5037925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect syntax highlighting for 'suspend' keyword.
Problem:
'suspend' was listed as @function.builtin but it's actually a modifier keyword, not a function. This caused wrong colors.
Changes:
highlights.scm: Removed "suspend" from builtin functions list
'suspend' is already highlighted correctly as a modifier via function_modifier and _type_modifier rules.
Example:
suspend fun fetchData() // 'suspend' is a modifier
// NOT a function like println()
Tests: 111/111 pass