Fix TS5011 in e2e tsconfig by setting explicit rootDir#25
Merged
Conversation
WDIO's config parser uses ts-node to compile wdio.conf.ts, and under TypeScript 6 the inferred common source directory becomes './helpers' (from the imported helper module), triggering TS5011. Setting rootDir to "." anchors compilation at the e2e root and unblocks CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Greptile SummaryAdds a single
Confidence Score: 5/5Safe to merge — a one-line config addition that fixes a TypeScript 6 compilation error without touching any runtime code. The change is confined to a single tsconfig field that aligns TypeScript's inferred root with the existing include glob. It has no effect on emitted output (since noEmit is inherited and ts-node uses transpileOnly), and the root tsconfig already isolates tests/e2e/ via exclude. No files require special attention. Reviews (1): Last reviewed commit: "Fix TS5011 in e2e tsconfig by setting ex..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun run test:e2efailed because WDIO's config parser (ts-node) hit TS5011 when loadingwdio.conf.tsunder TypeScript 6 — the inferred common source dir became./helpersfrom the helper import, which TS6 now requires to be explicit."rootDir": "."intests/e2e/tsconfig.jsonanchors compilation at the e2e root and unblocks the config load.Test plan
bunx wdio run tests/e2e/wdio.conf.tspreviously printed the TS5011 error twice and exited 1.onPrepare(mock server / Vite / app launch).test:e2ejob now passes the config-load step.🤖 Generated with Claude Code