Enable unconvert and revive linters#6386
Draft
toaster wants to merge 23 commits into
Draft
Conversation
This removes some unnecessary type conversions.
All modules causing warnings are disabled for now. The next commits will address all the TODOs.
For the built-in sizes, I deactivated the linter instead. It does not make much sense to add constants in this particular case. The color parsing was simplified.
…stants piggy-backed: - some revive-ignore comments - streamlining name of shader variable `cornerRadius` to `corner_radius`
…tants … or disabling the check
… or disabling the check piggy-backed: Remove weekday#String() which was only used for switch statements.
…onstants … or disabling the check
… or disabling the check
… or disabling the check
|
coverage: 59.868% (-0.03%) from 59.894% — toaster:lint/revive-add-constant into fyne-io:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR enables the
unconvertandrevivelinters viagolangci-lint.The former checks for unnecessary type conversions while the latter is a multi-purpose linter by its own.
The most complaining rules for
reviveare disabled for now. This PR only addresses the complaints of theadd-constantrule.The other rules will be addressed in follow-up PRs.
Checklist: