Added tests for errors plus config example #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test response for invalid drs_id Test response for invalid auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the response to invalid drs_id
Test the response to invalid auth (two versions in config file)
Also added optional name for test in config. Name is used as a prefix to the autogenerated name.
Simplified arguments to test_drs_object_info and test_drs_object_access.
Not sure if it is the best approach to make the error tests part of the current test phases. A separate phase for error handling might be better. However, the error tests are variants of the existing tests, so there is something to be said for using the original phases.