Overhaul pagination structures (#11, #12) #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change covers two issues, which were somewhat connected to each other: Issue 11: - Return paginated results for all list-valued responses - Follow GA4GH TASC pagination standard https://github.com/ga4gh/TASC/blob/main/recommendations/API%20pagination%20guide.md Issue 12: - Push down values that are common to all results into the individual items. * Benefit: more straightforward code for both client and server implementations * Drawback: larger response payload due to repeated values
|
Did we not decide that the top level collection/list would be named per the type of objects in the list? i.e. namespaces, schemas, schemaversions etc. There is no particular value in homogenizing them all as 'results', each needs to be handled specifically as its own type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change covers two issues, which were somewhat connected to each other:
Issue 11:
Issue 12: