Skip to content

#690: Quick start guidance#693

Open
brendanreardon wants to merge 8 commits into
ga4gh:v2from
brendanreardon:v2
Open

#690: Quick start guidance#693
brendanreardon wants to merge 8 commits into
ga4gh:v2from
brendanreardon:v2

Conversation

@brendanreardon

Copy link
Copy Markdown

Link to the corresponding Issue

Summary of the Pull Request

Our goal with this hackathon was the improve the Quickstart experience for people onboarding into Cat-VRS. This is a Pull Request consisting of contributions from @DanielPuthawala , @melissacline , and myself from the Hackathon at 2026 Connect. Changes consist of:

  • Adding a "Getting involved" and "Quick start" pages to the VRS readthedocs
  • Added a Makefile to examples/ that generates corresponding json versions of yaml examples, as well as a README for examples/ that serves as a table of contents.
  • Adding a Makefile a validation/ that generates corresponding json versions of the yaml validation files
  • Added pre-commit hooks to run the Makefile for both examples/ and validation/

@brendanreardon

Copy link
Copy Markdown
Author

After reviewing, I am still happy with the content of this PR

@larrybabb larrybabb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@larrybabb larrybabb added the public review ready The PR has been approved and cleared by GKS product leads and is ready for public review label Jun 23, 2026

@ahwagner ahwagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed these in detail (time) but am concerned that the examples may not validate; is that tested? Sorry to be obtuse here.

@brendanreardon

Copy link
Copy Markdown
Author

I haven't reviewed these in detail (time) but am concerned that the examples may not validate; is that tested? Sorry to be obtuse here.

It looks like this repo's test pass within the fork

(vrs) breardon@pomegranate:vrs-connect-hackathon$ pytest tests
==================================================== test session starts =====================================================
platform darwin -- Python 3.12.13, pytest-9.1.1, pluggy-1.6.0
rootdir: /Users/brendan/vrs-connect-hackathon
configfile: setup.cfg
plugins: anyio-4.14.1
collected 6 items

tests/test_basic.py .....                                                                                              [ 83%]
tests/test_examples.py .                                                                                               [100%]

===================================================== 6 passed in 1.22s ======================================================

With that said though, the examples are compiled into JSON directly from the existing YAML, so if they did not validate that would be an issue independent from this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

public review ready The PR has been approved and cleared by GKS product leads and is ready for public review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants