Adding support for overrides#257
Open
demianbrecht wants to merge 1 commit intogabrielfalcao:mainfrom
Open
Conversation
Owner
|
Hey, first of all, sorry for taking so long to answer. Secondly, I'm sorry that the CI server build failed, I'll be glad to merge this under 2 conditions:
overrides = {
'socket': {
'gethostname': _GETHOSTNAME,
'gethostbyname': _GETHOSTBYNAME,
'getaddrinfo': _GETADDRINFO,
},
}
@httpretty.activate(with_overrides=overrides)
def test_something():
requests.get("http://whatever.com") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use case where the 'localhost' value baked in for
gethostnameis insufficient as the hostname is actually meaningful. This patch provides the capability to override what httpretty patches. Currently, I'm simply mocking the attributes after .enable()is called, but there's something about mocking the mocker that doesn't sit well with me ;) Kinda makes me think that this is something that should be supported.If there's no opposition to the proposed addition, I'll add the feature to the docs before merge.