Open
Conversation
Fix PHP 8.1 compatibility issues and various bugs found during development and testing. Bug fixes: - Fix PHP 8.1 readonly class syntax compatibility - Fix test directory filtering in AllAppModulesFinder - Fix lazy service bindings to use addFactory correctly - Fix container service registration in tests - Improve type safety across framework components Improvements: - Update PHPStan and Psalm static analysis configs - Enhance AbstractFacade, AbstractFactory, AbstractProvider - Improve Bootstrap configuration handling - Better DependencyProviderResolver error handling - Enhanced DocBlockResolver with factory method support This ensures compatibility with PHP 8.1+ and improves overall code quality and type safety.
- Remove references to 8 nonexistent command classes from ConsoleProvider - Remove #[Deprecated] attribute referencing nonexistent class - Regenerate phpstan and psalm baselines - Fix cache test assertions for test-order independence
Chemaclass
force-pushed
the
fix/php81-compatibility
branch
from
38355b1 to
acfdfdc
Compare
Chemaclass
force-pushed
the
fix/php81-compatibility
branch
from
ab57ec6 to
9d61b70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes PHP 8.1 compatibility issues, resolves bugs in test directory filtering and service bindings, and improves static analysis configuration for better type safety.
Summary
Bug Fixes:
AllAppModulesFinderaddFactoryinstead ofaddBinding)Improvements:
AbstractFacade,AbstractFactory,AbstractProviderDependencyProviderResolverDocBlockResolverChanges
PHP 8.1 Compatibility:
Test Fixes:
MakeModuleCommandTestto match current command descriptionStatic Analysis:
Impact