Add flag to let users know when the provider is ready #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror if the useGadget hook is used outside the provider
jasong689
force-pushed
the
better-provider
branch
from
db79d0a to
4a1bb08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle NextJs subtleties we use
useEffectrun code to determine if we're embedded/in an install context viawindow.location. We also use query parameters to determine if we're the value ofisRootFrameRequest. This means there is a very short window of time where it is incorrect while theuseEffecthook runs. I think what we should do is provide a flag in our context to let the developer know that we're still initializing theProvider. I've also gone ahead and added code to guard against using theuseGadgethook outside of theProvidercloses GGT-2085