Introduce shopId in browserSession to set shop tenant#875
Merged
Conversation
20a29b8 to
4aaed11
Compare
infiton
approved these changes
Jul 11, 2025
infiton
left a comment
Contributor
There was a problem hiding this comment.
looks good; mind adding some type tests to make sure we have type errors if more than one option is passed
MillanWangGadget
approved these changes
Jul 11, 2025
9bda259 to
95c5c43
Compare
95c5c43 to
df97dea
Compare
a8be7b3 to
37e3078
Compare
infiton
approved these changes
Jul 15, 2025
infiton
left a comment
Contributor
There was a problem hiding this comment.
looks good I think you can ship this one first; you'll need to cut a new release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new property in
browserSession,shopId, that allows apps like Shopify theme app extensions to set up a session with a Shopify tenancy.This allows use cases like fetching publicly accessible data for the specific shop without manually passing in the shop ID.
This PR also allows setting authentication modes at the top level, i.e. no need to declare the modes under the
authenticationMode.Click here to see an example usage
Example usage:
Then the
shopInfoComponentshould render the payload from thegetCurrentShopglobal action with the current shop's data.PR Checklist
contentHashfunctionsChangelog
If this PR will affect change user-facing behaviour, add detailed information about the change here to prompt an AI generated changelog entry.
If no changelog is required, write
[no-changelog-required]in square brackets[].