Refactor schema inference #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jduff
commented
Apr 30, 2025
| }, | ||
| "dependencies": { | ||
| "fast-glob": "^3.3.2" | ||
| "fast-glob": "^3.3.2", |
Contributor
Author
There was a problem hiding this comment.
Moved these dependencies that are needed by inferSchemaFromExamplePayload
jduff
commented
Apr 30, 2025
| if (unknownPaths.some(([pattern, paths]) => pattern.test(metadata.name) && paths.includes(fullPath))) { | ||
| // we know this path is always null, so don't error | ||
| } else { | ||
| errors.push({ |
Contributor
Author
There was a problem hiding this comment.
This file is largely unchanged, except for this part and what is being returned. Instead of logging the errors and warnings here, we collect them and return it along with the schema.
jduff
commented
Apr 30, 2025
| await fs.writeFile(metadataFile, JSON.stringify(webhook, null, 2), "utf-8"); | ||
|
|
||
| const schema = inferSchemaFromExamplePayload(webhook.response, webhook, version); | ||
| const { schema, warnings: warningCount, errors: errorMessages } = inferSchemaFromExamplePayload(webhook.response, webhook); |
Contributor
Author
There was a problem hiding this comment.
This file is mostly the same except with the removed code moving to infer-schema. This is the main change, instead of the console output happening inside inferSchemaFromExamplePayload it is moved here.
airhorns
approved these changes
May 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the schema inference so it isn't coupled to
scraper.tsand can be imported and used in other codebases.src/infer-schema.tsinferSchemaFromExamplePayloadand put into the scraper.inferSchemaFromExamplePayloadand the function is now exported.package.jsonwas updated to add dependencies thatinferSchemaFromExamplePayloadneeds.